WIP: Graphql next #905
WIP: Graphql next #905
Conversation
|
This is great thank you @ulgens ! At the moment we are still working on getting Graphene v3 out so this might have to hang around for a bit until that happens. |
|
@ganwell On Travis, all of the test configs were called and they all pass except the ones allowed to fail: https://travis-ci.org/github/graphql-python/graphene-django/builds/663374515 |
That is a test with broken tox.ini: Line 3 in 49d897b I appreciate all the work you have done. And the reason why I want to start fresh from master is because I don't understand what is going on. I am sorry that I haven't much time the last two month. I just want to use the time I have to dig trough #905 and #774 by applying these slowly to master. |
|
@ganwell I created #904 with that mindset, and @jkimbo recommended that we should create a "3" branch and merge all of it in that. I'm okay with that path, and i'm not really sure applying these changes to master incrementally is an option. Without all the changes in this branch, you will always have at least one failing test. |
|
If you look at this: https://travis-ci.org/github/graphql-python/graphene-django/jobs/663374517 Nothing is tested. tox doesn't do anything. |
I will mark the tests that fail as |
|
@ganwell Okay, thank you. That was the kind of explanation i'm looking for about what is wrong. Checking it now. |
That means we're going to ship a broken package with tests allowed to fail. I fixed tox.ini and saw the errors you mentioned before, all of them can be fixed in a day. |
That would be great!! Thank you very much. I only proposed the slow way, because I don't understand graphene-django well enough. So I will work on the flaky tests on master instead, while you fix #905. I am glad we can avoid the slow way. |
|
@ganwell Thank you 🙂 So, for the anyone who is looking for the result of that conv., i'm pulling that PR to WIP status, will fix rest of the broken tests and hopefully, we will good to go tomorrow. |
We would make PRs to a branch called graphe-django-3.0, which will follow master and we would only merge to master once everything is fixed. This way we have small code-reviews and we don't pollute master. But hopefully this isn't needed. |
GraphQLError("Name '__debug' must not begin with '__', which is reserved
by GraphQL introspection."
…ray_slice connection_from_list_slice: > Deprecated alias for connection_from_array_slice. We're now using the JavaScript terminology in Python as well, since list is too narrow a type and there is no other really appropriate type name. https://github.com/graphql-python/graphql-relay-py/blob/v3.0.0/src/graphql_relay/connection/arrayconnection.py#L54
|
Closing this because #951 has been merged into the v3 branch. |
This PR is based on #904 . When it's merged, this branch should be rebased from main branch.
I tried to use existing PRs #812 and #774 and complete what is left. There is no proper organization in commits at the moment, i'll edit the branch in couple of days.
There are several things to discuss but it passes all tests and i think this is a good start.