Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmark for connection fields #259

Merged
merged 8 commits into from
Jan 24, 2020
Merged

Conversation

jnak
Copy link
Collaborator

@jnak jnak commented Jan 22, 2020

Add pytest-benchmark so we can easily track performance changes over time.

PS: It's been already approved by @Nabellaleen in my own repo jnak#1

katy-sadowski
katy-sadowski previously approved these changes Jan 22, 2020
Copy link

@katy-sadowski katy-sadowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello

Nabellaleen
Nabellaleen previously approved these changes Jan 22, 2020
@jnak jnak dismissed stale reviews from Nabellaleen and katy-sadowski via 90e73bb January 23, 2020 02:57
@jnak
Copy link
Collaborator Author

jnak commented Jan 24, 2020

@Nabellaleen For some reasons that I don't fully understand, our tests for Python 3.4 suddenly stopped working on master. It can no longer install PyYaml, a dependency of pre-commit, one our dev dependencies. I investigated a bit and it looks like it's due to an underlying issue in PyYaml. Given Python 3.4 has reached end of life in March 2019 and it's fairly easy to upgrade from Python 3.4, I don't think we should spend time trying to make the tests pass. I disabled the tests for Python 3.4. Nonetheless, I still expect graphene-sqlalchemy to work with Python 3.4 for the foreseeable future given that we don't use anything specific to Python 3.4.

Alas I also had to upgrade coveralls because of another new sudden issue.

@jnak jnak merged commit 631513f into graphql-python:master Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants