Rework codegen for GraphQL objects #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyranron
added
enhancement
|
@LegNeato this one is too huge, so I merge it without requesting your review. It's quite a breaking change, so, please, don't release |
This was referenced Aug 11, 2021
|
Sounds good, thank you for the great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #421
Superseeds #441
Partially related to #814
Fixes #525, #697, #827, #875, #880
Extends #765
This PR migrates
#[derive(GraphQLObject)],#[graphql_object]and#[graphql_subscription]macro implementations to the same machinery used by#[graphql_interface].Additionally, it changes codegen in the way, that computed fields are not desugared into async blocks, but rather are preserved as methods and called directly.
Checklist