fix tests

graphql · Aug 15, 2024 · be49600 · be49600
1 parent 51dd93e
commit be49600
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 16 deletions.
diff --git a/packages/graphiql/cypress/e2e/tabs.cy.ts b/packages/graphiql/cypress/e2e/tabs.cy.ts
@@ -99,7 +99,7 @@ describe('Tabs', () => {
 
       cy.get('.graphiql-tab-button + .graphiql-tab-close').eq(1).click();
 
-      cy.get('.graphiql-tab-button').should('have.length', 1);
+      cy.get('.graphiql-tab-button').should('have.length', 0);
     });
   });
 });
diff --git a/packages/graphiql/resources/renderExample.js b/packages/graphiql/resources/renderExample.js
@@ -8,20 +8,14 @@
  *
  * It is used by:
  * - the netlify demo
- * - end to end tests
+ * - end-to-end tests
  * - webpack dev server
  */
 
 // Parse the search string to get url parameters.
-const parameters = {};
-for (const entry of window.location.search.slice(1).split('&')) {
-  const eq = entry.indexOf('=');
-  if (eq >= 0) {
-    parameters[decodeURIComponent(entry.slice(0, eq))] = decodeURIComponent(
-      entry.slice(eq + 1),
-    );
-  }
-}
+const parameters = Object.fromEntries(
+  new URLSearchParams(location.search).entries(),
+);
 
 // When the query and variables string is edited, update the URL bar so
 // that it can be easily shared.
@@ -53,10 +47,6 @@ function confirmCloseTab(index) {
   return confirm(`Are you sure you want to close tab with index ${index}?`);
 }
 
-const searchParams = Object.fromEntries(
-  new URLSearchParams(location.search).entries(),
-);
-
 function updateURL() {
   const newSearch = Object.entries(parameters)
     .filter(([_key, value]) => value)
@@ -111,7 +101,7 @@ root.render(
     shouldPersistHeaders: true,
     inputValueDeprecation: GraphQLVersion.includes('15.5') ? undefined : true,
     confirmCloseTab:
-      searchParams.confirmCloseTab === 'true' ? confirmCloseTab : undefined,
+      parameters.confirmCloseTab === 'true' ? confirmCloseTab : undefined,
     onTabChange,
     forcedTheme: parameters.forcedTheme,
   }),