Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Ted Thibodeau Jr <[email protected]>
  • Loading branch information
dimaMachina and TallTed authored Aug 16, 2024
1 parent 47874bf commit d2daab6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .changeset/nasty-cows-train.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@
'graphiql': major
---

- Remove `query`, `variables`, `headers` and `response` props in `<GraphiQL />`, `<GraphiQLProvider />` and `<EditorContextProvider />`
- Remove `query`, `variables`, `headers`, and `response` props in `<GraphiQL />`, `<GraphiQLProvider />`, and `<EditorContextProvider />`

- Remove `useSynchronizeValue` hook
2 changes: 1 addition & 1 deletion packages/graphiql/cypress/e2e/headers.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ describe('Headers', () => {
cy.assertHasValues({ query: '', headersString: DEFAULT_HEADERS });
});

it('in case `headers` and `defaultHeaders` are set, `headers` should be on 1st tab and `defaultHeaders` for other opened tabs', () => {
it('if `headers` and `defaultHeaders` are set, `headers` should be on 1st tab and `defaultHeaders` for other opened tabs', () => {
const HEADERS = '{"bar":true}';
cy.visit(
`/?query={test}&defaultHeaders=${DEFAULT_HEADERS}&headers=${HEADERS}`,
Expand Down

0 comments on commit d2daab6

Please sign in to comment.