Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use flexbox standard syntax #250

Closed
gugadev opened this issue Dec 12, 2016 · 1 comment
Closed

Use flexbox standard syntax #250

gugadev opened this issue Dec 12, 2016 · 1 comment
Assignees
Labels

Comments

@gugadev
Copy link

gugadev commented Dec 12, 2016

It seems you guys have forgotten to place display: flex in the css classes.

This is the look under Firefox 45.x with default styles:

After add display: flex:

@wincent
Copy link
Contributor

wincent commented Dec 13, 2016

Thanks for the report! I couldn't repro this on Firefox 49 or 50 (didn't have access to 45), so I downloaded v45 and I can repro.

I suspect most people allow the auto-updater to keep them on a more recent version, but v45 is still pretty recent (April 2016, I think), and the cost of fixing the issue seems low, so we may as well do it.

@wincent wincent self-assigned this Dec 13, 2016
@wincent wincent added the bug label Dec 13, 2016
asiandrummer pushed a commit that referenced this issue Dec 13, 2016
Regression introduced in f9de007.

Tested on Firefox 45 (old, was broken), 49 (previous, still works), 50
(latest, still works) and Chrome 54 (current, still works).

Closes: #250
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants