Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4] polish tabs.cy tests, remove .graphiql-session class #3728

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

dimaMachina
Copy link
Collaborator

@dimaMachina dimaMachina commented Aug 14, 2024

I firstly did mistake and remove #graphiql-session id, I was thinking it nowhere used but it was used by aria-controls="graphiql-session"

Copy link

changeset-bot bot commented Aug 14, 2024

🦋 Changeset detected

Latest commit: 7286bfe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
graphiql Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dimaMachina dimaMachina changed the title [v4] remove id="graphiql-session" html attribute [v4] polish tabs.cy tests Aug 14, 2024
Copy link
Contributor

The latest changes of this PR are not available as canary, since there are no linked changesets for this PR.

@dimaMachina dimaMachina changed the title [v4] polish tabs.cy tests [v4] polish tabs.cy tests, remove .graphiql-session class Aug 14, 2024
@dimaMachina dimaMachina merged commit a1a5208 into graphiql-v4 Aug 14, 2024
14 checks passed
@dimaMachina dimaMachina deleted the remove-id-session branch August 14, 2024 21:38
@acao acao mentioned this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant