Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[graphiql-react] create instance of new HistoryStore and new StorageAPI only on mount, use function with useState #3743

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

dimaMachina
Copy link
Collaborator

No description provided.

Copy link

changeset-bot bot commented Aug 22, 2024

🦋 Changeset detected

Latest commit: fb8967e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphiql/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

The latest changes of this PR are available as canary in npm (based on the declared changesets):

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 36.84211% with 12 lines in your changes missing coverage. Please review.

Project coverage is 67.25%. Comparing base (26cd829) to head (fb8967e).
Report is 1 commits behind head on main.

Files Patch % Lines
packages/graphiql-react/src/history/context.tsx 33.33% 12 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3743      +/-   ##
==========================================
- Coverage   67.29%   67.25%   -0.04%     
==========================================
  Files         121      121              
  Lines        7017     7012       -5     
  Branches     2269     2263       -6     
==========================================
- Hits         4722     4716       -6     
- Misses       2278     2279       +1     
  Partials       17       17              
Files Coverage Δ
packages/graphiql-react/src/storage.tsx 81.81% <100.00%> (ø)
packages/graphiql-react/src/history/context.tsx 52.00% <33.33%> (-11.34%) ⬇️

@dimaMachina dimaMachina merged commit 7275c19 into main Aug 22, 2024
14 checks passed
@dimaMachina dimaMachina deleted the use-state-fn branch August 22, 2024 17:40
This was referenced Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant