-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] adding 'subscription' language to GraphQL spec #109
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,14 +17,16 @@ operations” section. | |
## Evaluating operations | ||
|
||
The type system, as described in the “Type System” part of the spec, must | ||
provide a “Query Root” and a “Mutation Root” object. | ||
provide a “Query Root” and a “Mutation Root” object, and can provide an optional | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This existing phrase isn't quite correct. Do you mind amending to: The type system, as described in the "Type System" part of the spec, must provide a "Query Root" and may optionally also provide a “Mutation Root” or a "Subscription Root" object. |
||
“Subscription Root” object. | ||
|
||
If the operation is a mutation, the result of the operation is the result of | ||
evaluating the mutation’s top level selection set on the “Mutation Root” | ||
object. This selection set should be evaluated serially. | ||
|
||
If the operation is a query, the result of the operation is the result of | ||
evaluating the query’s top level selection set on the “Query Root” object. | ||
If the operation is a query or a subscription, the result of the operation is | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is over-specified. The evaluation of a subscription should be considered experimental and intentionally under-specified at the moment. |
||
the result of evaluating the operation's top level selection set on the “Query | ||
Root” object or the “Subscription Root” object, respectively. | ||
|
||
## Evaluating selection sets | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This bit is over-specified. A subscription doesn't have to do a retrieve then subscription, it probably only creates the subscription.