Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

mask on expiry on credit-card.html is problematic #18

Closed
chadwhitacre opened this issue Jun 6, 2012 · 0 comments
Closed

mask on expiry on credit-card.html is problematic #18

chadwhitacre opened this issue Jun 6, 2012 · 0 comments

Comments

@chadwhitacre
Copy link
Contributor

tabbing in and out of it is jarring

09 shows up goofy when you reload the page
@chadwhitacre chadwhitacre mentioned this issue Jan 24, 2013
Closed
chadwhitacre added a commit that referenced this issue Feb 5, 2013
@chadwhitacre
Fix typo; #18
625fbae 
We got a pull request from @imathis for #18. Since it's not ready to
merge automatically, it's a chance for me to learn and practice the
"manual" approach to pull requests. I've fetched his branch, merged
master to it, and this fixes a typo. There are a couple failing test to
address, and then I can actually review the code. :-)
chadwhitacre added a commit that referenced this issue Feb 5, 2013
@chadwhitacre
Clean up #18
ef6503e 
Here's what I did:

 - Took out redundant getters and modified tests to expect ints
 - Standardized on 'expiration' instead of 'expiry'
 - Reverted to former FORM width, tweaking only expiration field
 - Stuck with pixels for FORM layout (a switch to em should be done as a
   whole, and #66 surely affects this)
 - Show expiration error before CVV to match order in UI
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chadwhitacre