Show when a project is misconfigured

[chadwhitacre]

Reticketed from #3666 (comment).

When a Team's payout route fails or is disconnected (cf. #3681), then we should reflect in the UI the fact that the Team isn't actually receiving payments:

• The Giving page should include a "Broken"(?) tab in addition to the Active and Cancelled tabs.
• The giving and receiving caches shouldn't include broken payments.

What are the conditions for successful payment? How else can payments be broken?

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[chadwhitacre]

"Broken"(?)

Maybe "Inactive" to parallel "Active"?

[chadwhitacre]

The point is that it would work except for a circumstance outside of the giver's control (and probably inside of the giver's[sorry:] receiver's control—though, consider Team rejections).

[chadwhitacre]

I'm not going to get to this on the Pivot milestone.

[chadwhitacre]

I've created a new Refund Announcement milestone (see gratipay/inside.gratipay.com#326 (comment)) and added this to Pivot.

[aandis]

Thinking about landing this next. Here's how I think to go about this

1. Create a has_payout_route column in payment_instructions which would be true if owner of the team has paypal set up and false otherwise.
2. Calculate receiving of the team taking into consideration only those rows of payment_instructions where is_funded is true and has_payout_route is true.
3. Calculate giving of the participant taking into consideration only those rows of payment_instructions where is_funded is true and has_payout_route is true.
4. Reflect all payment_instructions where has_payout_route is false or is_funded is false on the Inactive tab of the Giving page.

Suggestions?
cc: @whit537 @rohitpaulk

[aandis]

Here's how I think to go about this ...

This is all well and good but I still don't understand how #3666 (comment) could happen.

According to my "Giving" page, I'm giving to two teams, but the summary seems to only take one into account

Reason mentioned in #3666 (comment) is

That could be because the ~owner of the other Team you give to doesn't have a PayPal attached (#3681),

But this can't be because till now we don't check whether owner has paypal set up while calculating giving amounts for participants. I am only proposing to add it now.

Either this has something to do with payday which I don't have complete idea about, yet, or it was wrongly reported.

[mattbk]

Changing the payday algorithm last year affected a bunch of things. Right now, ~book's page doesn't even report him as giving at all, which is not true. @aandis, do you have admin access to be able to see ~user information at gratipay.com?

[aandis]

~book's page doesn't even report him as giving at all, which is not true

It's not? Why would that be?

do you have admin access

Nope. I can see ~book giving $0.00

[mattbk]

@whit537, can we give @aandis the admin bit so he can see how Gratipay.com is actually behaving?

[chadwhitacre]

Done! Welcome to the League of Admins, @aandis. With great power comes great responsibility! :-)

=> select username, is_admin from participants where is_admin;
┌────────────┬──────────┐
│  username  │ is_admin │
├────────────┼──────────┤
│ clone1018  │ t        │
│ rohitpaulk │ t        │
│ aandis     │ t        │
│ whit537    │ t        │
│ mattbk     │ t        │
└────────────┴──────────┘
(5 rows)

[aandis]

woah. _chiils_. Thanks @whit537 :)

[aandis]

~book's page doesn't even report him as giving at all, which is not true

@mattbk I see now. But I think this behavior is correct since ~book doesn't have credit card setup. So showing $0.00 in giving makes sense. Only thing wrong is that payment_instruction are shown in the Active tab. They should instead be shown in the Inactive tab which would happen once this issue is resolved.

[mattbk]

That's the part that's confusing to me (and maybe to ~book). If a ~user is taking from a team and has enough to cover giving, it's confusing that their tips don't work. This must have been explained to me before.

Moving "unfunded" into inactive makes sense in this case. It should definitely be clear why this is the case (help text on Inactive tab) and an alert added if there isn't one yet (something scary like "your account is broken and you aren't tipping anyone).

Additionally this is one of the things I think we should email people about on payday. Do we do that already? "You are attempting to give but we can't do that because x."

[chadwhitacre]

Bump. One of four left on Finish Team Basics. Update, @aandis?

[aandis]

What I have proposed should work except that it'll also need to take care of -

If a ~user is taking from a team and has enough to cover giving, it's confusing that their tips don't work.

I am going to have to go over payday to understand how it handles that so that the actual numbers match with what is supposed to happen at payday.

[kaguillera]

@aandis I was just wondering if you had any progress on this. Just curious...

[mattbk]

I recently saw a comment by @rohitpaulk that explained (to a user) how this worked, but I can't seem to locate it...

EDIT: #3666 (comment)

[aandis]

@kaguillera I did intend to start this but didn't get a chance to go over payday. Removing my assignment for now. ;)

[aandis]

Although I give to gratipay, my giving doesn't reflect that. I realize this issue is about misconfigured teams, but I couldn't find an issue about user's misconfigured caches. Is there an existing issue for this?

[chadwhitacre]

Hmm ... maybe #4064 or #4120?

[mattbk]

@aandis, didn't you answer this yourself at #3727 (comment)?

[aandis]

@mattbk that was before I realized that if a user's takes is enough to cover his giving, he'll actually be able to give to that team on payday irrespective of whether he has a cc setup or not. So since ~book takes from multiple teams and has enough to give to other teams, his giving should show the amount given.

[chadwhitacre]

When a Team's payout route fails or is disconnected

Actually, we still collect even when the route is failing. 🐭

In any case, I'm dropping this from the "Finish Project Basics" milestone because I think don't need to block other work on it.

[mattbk]

Digging into #4367 and finding similar behavior to this:

Although I give to [project], my giving doesn't reflect that.

@aandis, as a fellow team member, I'm going to use your simple giving/taking as an example. You're receiving from Gratipay, and giving an equal amount to Gratipay (!):

...but your giving doesn't show up. Mustn't this be because you don't have a credit card attached?

[mattbk]

Additionally this is one of the things I think we should email people about on payday. Do we do that already? "You are attempting to give but we can't do that because x."

Also, "We have money for you, but can't payout because you have no route set up."

[mattbk]

I guess it should be opt-in like other emails, e.g.,