This repository has been archived by the owner on Feb 8, 2018. It is now read-only.
Connected accounts restyle #2142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accounts with avatars, and the new Disconnect button, still need to be looked at. Markup and styles were copied over from the coinbase repo. Re-used an existing colour variable instead of making a new one that was used.
Balanced is implemented without the account-row macro, so it requires a bit of manual tweaking.
chadwhitacre
added a commit
that referenced
this pull request
Mar 14, 2014
Connected accounts restyle
chadwhitacre
added a commit
that referenced
this pull request
Mar 14, 2014
The close button for accounts elsewhere was not implemented properly in #2142. Due to the way our CDN is implemented, CSS background URLs need to be specificed relative to the /assets/%version directory to work properly in both development and production. I also switched from _ to - to match existing naming conventions.
Merged
chadwhitacre
added a commit
that referenced
this pull request
Mar 14, 2014
It uses a wrong pattern (absolute CSS URLs) and is unused at the moment. See #2142.
This was referenced Mar 14, 2014
Merged
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Smaller chunk of #2053 than #2124 was.