Break anonymity #3112

chadwhitacre · 2015-01-13T04:39:28Z

This PR breaks anonymity with a double opt-in, closing #236.

chadwhitacre · 2015-01-13T04:46:10Z

New knob on Account page:

chadwhitacre · 2015-01-13T04:49:09Z

I suggest we broaden the "Hide total {giving,receiving} from others" to encompass specific {giving,receiving} as well.

chadwhitacre · 2015-01-13T04:53:10Z

P.S. I started this PR because both @weallhave24hrs and @renaantosz need it to really start using Gratipay in earnest, and they're the ones whose use cases I'm personally prioritizing right now. In other words, I'm personally shifting from the "Pay Your Heroes" roadmap, which was focused on the "individual giving to another individual" case, to a new roadmap focused on the "individual giving to a business" use case. This is based on the retreat, which I ~~still need to blog about~~ blogged about.

seanlinsley · 2015-01-13T05:01:00Z

+1 in general. I'll work on reviewing this tomorrow

!m @whit537

clone1018 · 2015-01-13T12:12:34Z

www/%username/account/index.html.spt

+            <label class="anonymous-supporters">
+                <input type="checkbox"
+                    {% if not participant.anonymous_supporters %}checked="true"{% endif %} />
+                    {{ _("Allow my supporters to divulge themselves.") }}


I don't feel like this is very descriptive. If you want to keep it we should at least have hover state help text.

Just a thought:

Allow anyone:

To see how much I give

To see how much I receive

To search for me

Allow people I support:

To see I support them

To show I support them on their profile

To be shown on my profile

Allow people that support me:

To show me they support me

To show they support me on their profile

To be shown on my profile

Edit: So this is kind of similar to: #236 (comment)

Edit 2: IRC

blrhc · 2015-01-13T20:37:38Z

Completely agree with @clone1018, this functionality needs to be explained better in the labels.
Overall though, a great function. !m @whit537!

chadwhitacre · 2015-01-27T21:03:18Z

I printed out and am rereading #236. The full implementation of #236 gets complicated. On this PR I want to focus on the minimum necessary for @weallhave24hrs @renaantosz, though I want to do it in a way that makes sense in terms of the bigger picture on #236, so that's why I'm rereading that.

chadwhitacre · 2015-01-27T21:04:19Z

I also want to look at the specific use cases mentioned on #236. I'm thinking of @jdorfman @JEdgar @iElectric etc.

domenkozar · 2015-01-27T21:06:33Z

It covers the use case for Kiberpipa.

chadwhitacre · 2015-01-27T21:13:40Z

@iElectric Do you need to know how much someone is giving, or just that they're giving? Does it need to be public that they're giving to you or is it enough if you can see that info?

chrisdev · 2015-01-27T21:13:59Z

@whit537 I've got a client https://gratipay.com/birdsongtt/ that is a government registered charity. They would like to give out receipts to donors for tax purposes. Knowing their donors is a prerequisite for this.
I've got a couple more like this coming on stream in the next couple of months. Hoping that this change fits this use case

chadwhitacre · 2015-01-27T21:15:27Z

@chrisdev Do they need amounts given, or just identity of givers?

domenkozar · 2015-01-27T21:15:45Z

@whit537
as Kiberpipa
We should see how much is someone donating to us
So that we can account for member fees.

chadwhitacre · 2015-01-27T21:16:12Z

@iElectric Okay, thanks for the input.

chrisdev · 2015-01-27T21:17:06Z

@whit537 ideally we need names and amount. But as a second best option the name is good enough

chadwhitacre · 2015-01-27T21:18:06Z

@chrisdev Okay, it sounds like @iElectric needs amount, and I know that @renaantosz does as well. So let's consider amount a requirement for this PR to cover your use cases.

chrisdev · 2015-01-27T21:19:01Z

💃 @whit537

chadwhitacre · 2015-01-27T21:23:14Z

Gosh, this is a complicated matrix. It's even more complicated than @balupton's helpful matrix at #236 (comment), because for @chrisdev's charities case to work we actually need the ability to require non-anonymity. I.e., "Only accept tips from people who are willing to divulge their identity to me."

chadwhitacre · 2015-01-27T21:33:48Z

There's which side of the transaction you're on: 1) giver, 2) receiver.

There's what piece of info is shared: 1) identity, 2) amount, 3) reason.

There's where it's shared: 1) privately on the other's profile, 2) publicly on other's profile, 3) publicly elsewhere (community page? third-party site?).

There's sharing restrictions: only allow givers with XYZ configuration.

There's default settings and then per-tip overrides.

chadwhitacre · 2015-01-28T02:20:53Z

We don't have tip reasons/messages yet and we shouldn't add that on this PR, so let's take that out of the consideration for now.

This adds fields to the database to support non-anonymous giving.

I think we should only divulge identity on the Receiving page for transfers, not for tips, in which case we don't need a new field on tips after all.

chadwhitacre · 2015-01-28T02:47:55Z

Rebased on master.

chadwhitacre · 2015-01-28T21:23:20Z

chadwhitacre · 2015-01-28T21:31:51Z

Okay! Been going around and around the horn here at Blue Canary with @rummik @kaguillera @dmk246 @renaantosz @EileenFord. #3112 (comment) represents the consensus we've come to over here about the privacy options we want to present to users with this PR.

chadwhitacre · 2015-01-30T21:44:07Z

The build is breaking at Travis because we don't have the json type in Postgres?

chadwhitacre · 2015-01-30T21:54:40Z

Restarted, now seeing failures properly (due to inversion of privacy booleans). Also seeing failures locally.

rummik · 2015-02-01T18:11:46Z

I'm not sure on the Who pays you what, exactly? text, since it feels like the wording is too different from the above options. I'd suggest something more along the lines of:

Information about your supporters:
Who they are, and how much they pay you.

Do not show me information about my supporters.
Allow my supporters to choose.
Require my supporters to tell me.

chadwhitacre · 2015-02-02T16:13:58Z

How about this for the tip override UI?

chadwhitacre · 2015-02-02T16:18:50Z

the wording is too different from the above options

This section is different from the above options. If anything, we should set it off with a different heading. We raised but didn't settle the question of whether this is even properly a "privacy" option. It's not about my privacy, it's about my supporter's privacy. "Sharing" could encompass both.

chadwhitacre · 2015-02-02T19:11:50Z

As I'm implementing the per-tip overrides, it occurs to me that the implementation at #3112 (comment) has it that I'll be able to individually set who of my supporters is displayed publicly. I guess that happens on the receiving page? We can also email people when they get new supporters. I guess public_supporters encodes the default, then.

chadwhitacre · 2015-02-02T19:32:22Z

Or is that too complicated? Should we give both giver and receiver the ability to override individual tips? Or should we just give that ability to givers?

chadwhitacre · 2015-02-02T19:40:57Z

What if you require knowledge and then unrequire it? Do you get your former supporters back? Maybe within a certain timeframe?

We don't need the nested else since we raise under the if.

rohitpaulk · 2015-02-03T03:38:50Z

What if you require knowledge and then unrequire it? Do you get your former supporters back? Maybe within a certain timeframe?

I think the simplest way to implement this would be to handle it like we handle changes from a Team to Individual account. i.e When they click on 'require details', show them a warning that says that all their anonymous tips will be cancelled if they make this change.

rummik · 2015-02-03T07:42:50Z

@whit537 What I mean is that I feel like the abrupt question starting the section isn't very clear, and adds confusion to it, since we don't do that anywhere else

synconme · 2015-02-05T22:54:34Z

Just a suggestion regarding the options, maybe it is more convenient to simplify options a little bit, something like that:

Show other users:

Require my supporters tell me who they are and amount they give

From my point of view, if receiver wants to know who donates her, it is more likely she want to know the amount as well.

chadwhitacre · 2016-04-09T21:05:57Z

I'm scrapping this for parts.

chadwhitacre added the 3 - Work in Progress label Jan 13, 2015

clone1018 reviewed Jan 13, 2015
View reviewed changes

rohitpaulk mentioned this pull request Jan 20, 2015

Get some kind of callback from Gratipay after user successfully donated #3126

Closed

chadwhitacre added 4 commits January 27, 2015 21:47

Start breaking anonymity

5e973ad

This adds fields to the database to support non-anonymous giving.

Reorganize account.js to match order in UI

973ec9e

Add "Supporter Identity" to account page

1afa1ba

Actually, I don't think we need is_anon in tips

c55fcf5

I think we should only divulge identity on the Receiving page for transfers, not for tips, in which case we don't need a new field on tips after all.

chadwhitacre force-pushed the break-anonymity branch from ac23d34 to c55fcf5 Compare January 28, 2015 02:47

Fix up codebase for inverted booleans

d07fb51

chadwhitacre added 3 commits February 2, 2015 15:00

Unfrobulate tip.json logic

c7cb88f

We don't need the nested else since we raise under the if.

Rough in per-tip privacy overrides

bb382d1

Fix up 80% of the test suite

228352b

Changaco added the ★★☆ label Feb 23, 2015

Changaco mentioned this pull request Mar 6, 2015

discuss roadmap based on information architecture #3220

Closed

jiri-janousek mentioned this pull request Mar 8, 2015

Automatically pause when headphones are unplugged [$5] tiliado/nuvolaplayer#80

Closed

chadwhitacre removed the 3 - Work in Progress label Mar 31, 2015

Changaco mentioned this pull request Apr 1, 2015

let's talk about process gratipay/inside.gratipay.com#163

Closed

chadwhitacre mentioned this pull request Aug 21, 2015

turn communities off #3700

Closed

chadwhitacre mentioned this pull request Sep 2, 2015

allow for underwriting as a business #988

Closed

chadwhitacre mentioned this pull request Dec 29, 2015

Allow Teams to see who is giving in order to provide extra service #3883

Closed

chadwhitacre removed the ★★☆ label Mar 4, 2016

chadwhitacre added this to the Solve Corporate Sponsorship of Open-Source milestone Apr 9, 2016

chadwhitacre closed this Apr 9, 2016

chadwhitacre deleted the break-anonymity branch April 9, 2016 21:06

chadwhitacre mentioned this pull request Jan 20, 2017

should be able to give non-anonymously #236

Closed

chadwhitacre mentioned this pull request Jun 16, 2017

Link to givers from project history for admin #4490

Closed

Break anonymity #3112

Break anonymity #3112

Conversation

chadwhitacre commented Jan 13, 2015

chadwhitacre commented Jan 13, 2015

chadwhitacre commented Jan 13, 2015

chadwhitacre commented Jan 13, 2015

seanlinsley commented Jan 13, 2015

clone1018 Jan 13, 2015

Choose a reason for hiding this comment

rummik Jan 16, 2015

Choose a reason for hiding this comment

blrhc commented Jan 13, 2015

chadwhitacre commented Jan 27, 2015

chadwhitacre commented Jan 27, 2015

domenkozar commented Jan 27, 2015

chadwhitacre commented Jan 27, 2015

chrisdev commented Jan 27, 2015

chadwhitacre commented Jan 27, 2015

domenkozar commented Jan 27, 2015

chadwhitacre commented Jan 27, 2015

chrisdev commented Jan 27, 2015

chadwhitacre commented Jan 27, 2015

chrisdev commented Jan 27, 2015

chadwhitacre commented Jan 27, 2015

chadwhitacre commented Jan 27, 2015

chadwhitacre commented Jan 28, 2015

chadwhitacre commented Jan 28, 2015

chadwhitacre commented Jan 28, 2015

Privacy

chadwhitacre commented Jan 28, 2015

chadwhitacre commented Jan 30, 2015

chadwhitacre commented Jan 30, 2015

rummik commented Feb 1, 2015

chadwhitacre commented Feb 2, 2015

chadwhitacre commented Feb 2, 2015

chadwhitacre commented Feb 2, 2015

chadwhitacre commented Feb 2, 2015

chadwhitacre commented Feb 2, 2015

rohitpaulk commented Feb 3, 2015

rummik commented Feb 3, 2015

synconme commented Feb 5, 2015

chadwhitacre commented Apr 9, 2016