Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

find friends #3185

Merged
merged 46 commits into from
Apr 8, 2015
Merged

find friends #3185

merged 46 commits into from
Apr 8, 2015

Conversation

chadwhitacre
Copy link
Contributor

Here's a proposal for how to implement #3183 (really, I'm looking at #536).

  • cache friend calls
  • add pagination to table
  • add search filter to table
  • add sorting to table
  • abstract for other elsewheres
  • implement or stub other elsewheres
  • figure out how to handle Facebook limitations
  • add elsewhere logo as sidebar avatar
  • link to attached networks from dashboard

@chadwhitacre
Copy link
Contributor Author

Basically, the idea here is that /on/twitter/ becomes the friend-finder for Twitter, etc. I'm thinking we use a table like we're using on Explore, Members, Receiving, Giving.

@chadwhitacre
Copy link
Contributor Author

I've reopened #536 for this, because I think this address that more directly than #3183.

@chadwhitacre
Copy link
Contributor Author

screen shot 2015-02-17 at 2 46 37 pm

@rohitpaulk
Copy link
Contributor

That's awesome :)

@rohitpaulk
Copy link
Contributor

screenshot from 2015-02-25 16 44 51

Hmm, maybe I should've used the sub-nav like we do on Explore?

screenshot from 2015-02-25 16 48 21

@rohitpaulk
Copy link
Contributor

Here's how that'd look -

screenshot from 2015-02-25 17 23 38

@chadwhitacre
Copy link
Contributor Author

@rohitpaulk I like #3185 (comment)!

@rohitpaulk
Copy link
Contributor

This is what I'm aiming for:

screenshot from 2015-02-26 11 08 13

@Changaco
Copy link
Contributor

We can't show "x of them are on Gratipay" until we've fetched all the pages, and we can't quickly fetch all the pages for users who have lots of "friends" because of rate limiting.

@chadwhitacre
Copy link
Contributor Author

@Changaco Changaco force-pushed the friends branch 7 times, most recently from 4bd00d9 to f64d254 Compare March 27, 2015 13:56
@Changaco
Copy link
Contributor

Ready for review.

I think caching, filtering and sorting can wait for #3222.

@Changaco
Copy link
Contributor

Note: I've been unable to test the Facebook friend finder, it looks like our test app isn't setup properly.

@rohitpaulk
Copy link
Contributor

Added a few commits. I think this is good to merge. cc: @Changaco

@rohitpaulk
Copy link
Contributor

Screenshots for the pagination styling change (11b9441)

Before:

screenshot from 2015-04-08 11 37 26

After:

screenshot from 2015-04-08 11 36 48

Changaco added a commit that referenced this pull request Apr 8, 2015
@Changaco Changaco merged commit efc7b24 into master Apr 8, 2015
@Changaco Changaco deleted the friends branch April 8, 2015 07:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants