This repository has been archived by the owner on Feb 8, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 308
find friends #3185
Merged
find friends #3185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically, the idea here is that |
chadwhitacre
force-pushed
the
friends
branch
from
February 17, 2015 16:22
503ab4f
to
5630740
Compare
That's awesome :) |
Changaco
force-pushed
the
friends
branch
3 times, most recently
from
February 25, 2015 09:13
79d9bb9
to
88cac84
Compare
@rohitpaulk I like #3185 (comment)! |
We can't show "x of them are on Gratipay" until we've fetched all the pages, and we can't quickly fetch all the pages for users who have lots of "friends" because of rate limiting. |
Changaco
force-pushed
the
friends
branch
7 times, most recently
from
March 27, 2015 13:56
4bd00d9
to
f64d254
Compare
Ready for review. I think caching, filtering and sorting can wait for #3222. |
Note: I've been unable to test the Facebook friend finder, it looks like our test app isn't setup properly. |
Added a few commits. I think this is good to merge. cc: @Changaco |
Screenshots for the pagination styling change (11b9441) Before: After: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a proposal for how to implement #3183 (really, I'm looking at #536).