-
Notifications
You must be signed in to change notification settings - Fork 308
Conversation
!m @rohitpaulk |
Once #3415 settles down let's figure out how to merge #3399 (comment) and this. |
bb18844
to
11c47bd
Compare
Rebased on master. |
INSERT INTO subscriptions | ||
(ctime, mtime, subscriber, team, amount, is_funded) | ||
SELECT ctime | ||
, mtime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would leave this out and let mtime
be set to now
. No?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I'm not sure. We use mtime
to show when the tip was last modified in the UI (Last set). Do we want that to be the time when the user last set it, or the time when we migrated the tip?
I suppose we want to run this when we approve a team for the first time. |
How does this compare with the SQL I used the other day? |
That excludes tips from suspicious/closed/unclaimed accounts and also checks for |
Should we also send the tippers ( |
@rohitpaulk Yes, definitely. Good call. |
We should go back and notify the new subscribers from last week as well. |
Rebased on master. |
@whit537 - I'm going to use this for #3486 (comment), can you have a look and merge it in? |
Yes, just reread it, looks good. Go ahead and merge once Travis runs green. |
Create a migrate tips function
Deploying... |
Deployed. |
Awesome. Now to call it for the users in question? |
I tested this on a backup, I can confirm that tips are migrated and an error is raised if the migration is attempted twice. |
Yep. Heading back to #3486... |
For #3399, includes #3420