This repository has been archived by the owner on Feb 8, 2018. It is now read-only.
rejected -> closed #3678
Merged
rejected -> closed #3678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Rejecting" teams is too harsh a term for the situation we want to optimize for, wherein we reach a decision collaboratively together with team owners about whether they and we are a good fit for each other. I think we should use the term "closed" instead. That leaves ambiguous the circumstances surrounding the closing, whereas "rejected" only covers the harshest case, wherein Gratipay acts despite the owner's intention. A "closed" account could be closed by the owner's decision, by Gratipay's, or by both agreeing together.
|
Ping @mattbk @kzisme @rohitpaulk et al. |
| @@ -37,7 +37,7 @@ title = name = team.name | |||
| <div class="col0"> | |||
| {% if team.is_approved in (None, False) %} | |||
| {% if team.is_approved == None %}unreviewed{% endif %} | |||
| {% if team.is_approved == False %}rejected{% endif %} | | |||
| {% if team.is_approved == False %}closed{% endif %} | | |||
There was a problem hiding this comment.
I'm not sure if it's used anywhere, but it would be cleaner to use the status property -
gratipay.com/gratipay/models/team.py
Line 83 in 8e36915
There was a problem hiding this comment.
Good find! I looked for that in the database schema, I didn't think to check for a computed property.
There was a problem hiding this comment.
Fixed up in 2e9919b.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Rejecting" teams is too harsh a term for the situation we want to optimize for, wherein we reach a decision collaboratively together with team owners about whether they and we are a good fit for each other. I think we should use the term "close" instead. That leaves ambiguous the circumstances surrounding the closing, whereas "rejected" only covers the harshest case, wherein Gratipay acts despite the owner's intention. A "closed" account could be closed by the owner's decision, by Gratipay's, or by both agreeing together.