This repository has been archived by the owner on Feb 8, 2018. It is now read-only.
implement tabs for Team review state #3740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This was referenced Sep 1, 2015
|
How did I get here? Oh, yes: the N=75 was a lie since we were in fact also listing non-approved Teams. The N on the welcome popup matched the N of the page itself, and I think it should. Since we do want to include under review and rejected Teams on the anon homepage (openness! :), and we don't want to confuse first-time visitors with an N (and a page, really) that includes unapproved Teams, we had to unlie the N another way: by moving unapproved Teams off the main page. |
|
This abstracts the tab infrastructure that @rohitpaulk introduced for Giving. |
chadwhitacre
added a commit
that referenced
this pull request
Sep 1, 2015
implement tabs for Team review state
|
Blorg. I forgot a file and force-pushed the merge off master. New PR is #3741. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picks off another todo on #3704.