Team name restrictions #3943

aandis · 2016-03-06T10:28:15Z

aandis · 2016-03-07T17:38:18Z

@mattbk this look good?

rohitpaulk · 2016-03-07T18:02:16Z

www/teams/create.json.spt

@@ -71,6 +71,11 @@ if request.method == 'POST':
                                  ))

    try:
+        fields['slug'] = slugize(fields['name'])
+    except AssertionError:


I think it'd make more sense to throw a custom error - InvalidTeamName, maybe

wokay! It did cross my mind too but it looked like a bit too much. :)

Another reason I didn't do this is that slugize is from community model. So having Invalid*Team*Name in there wouldn't really fit well. Now that you mentioned #3426, this would make sense since team model would have a slugize of its own.

mattbk · 2016-03-07T19:39:34Z

I can't test right now, but looks like you're on the right track.

mattbk · 2016-03-07T23:56:53Z

It's funny that you can't use these characters when creating a new team, but you can edit your team name to include any characters you want.

mattbk · 2016-03-08T00:05:15Z

Hmm, my error messages are stacking up:

mattbk · 2016-03-08T00:10:40Z

A team name of all underscores collapses into a team with a name of length zero, and the form completes. The team ends up under Review, but the link goes nowhere.

It looks like all underscores and periods collapse into "-" if they are between alphanumerics. In that case, I wouldn't include them in the list of approved characters?

rohitpaulk · 2016-03-08T03:54:29Z

It looks like all underscores and periods collapse into "-"

Side-effect of #3426, looks like

aandis · 2016-03-08T17:32:31Z

you can't use these characters when creating a new team, but you can edit your team name to include any characters you want.

There's a reason for this. You can't include those characters while creating the team because we use those characters to create a (unique) slug for the team and the current method which does that expects only certain characters. But when editing the team, the slug is already created and you can't really change it, so you should be free to edit your team name however you want.

mattbk · 2016-03-08T17:58:45Z

Okay, thanks, that makes sense.

aandis · 2016-03-09T16:16:03Z

Alright. Fixed #3880 and #3426 in this pr. Ready for review.

aandis · 2016-03-10T18:02:28Z

I added the team name regex such that things like #3943 (comment) can be avoided.

mattbk · 2016-03-14T22:06:34Z

It works for me. I'm happy with it as long as someone else thinks the new slugize works right. @whit537 @rohitpaulk ?

chadwhitacre · 2016-03-15T15:57:15Z

Reviewing ...

chadwhitacre · 2016-03-15T15:58:54Z

Rebased on master at af05120. Previous head was 8fa155e.

chadwhitacre · 2016-03-15T16:49:00Z

www/new.spt

@@ -58,6 +57,7 @@ still_migrating = delta > 0
    <input type="hidden" name="csrf_token" value="{{ csrf_token }}">

    <label><h2>{{ _("Team Name") }}</h2></label>
+    <p><i>{{ _("Must contain alphabets. Can optionally contain numbers, dashes (-), underscores (_), periods (.), comma (,) and whitespaces.") }}</i></p>


I'm not familiar with this usage of "alphabets." Perhaps it's part of Indian English?

heh. It's petty common over here. I just realized myself that it's wrong though. 😳

No worries ... maybe we should have an Indian English translation! 💃

Well, "localization" is probably the better word. ;-)

"23456789" technically does not contain invalid characters. ;-)

chadwhitacre · 2016-03-15T17:45:49Z

Rebased to remove 3c0d72f in favor of cbe6dd7. Previous head was 48f9ae6.

chadwhitacre · 2016-03-15T17:47:13Z

~~Rebasing again to fix~~ Fixing a couple tests ...

chadwhitacre · 2016-03-15T17:57:09Z

@aandis I'm ready to merge if you're good with my latest commits ...

aandis · 2016-03-15T18:03:20Z

Commented on 3c0d72f#commitcomment-16714701

chadwhitacre · 2016-03-15T18:08:06Z

@aandis Back in 2196bd6. :)

aandis · 2016-03-15T18:14:54Z

Looks good to me. 👍

Team name restrictions

chadwhitacre · 2016-03-15T18:16:45Z

!m @aandis

aandis · 2016-03-15T18:20:49Z

!m @whit537

rohitpaulk reviewed Mar 7, 2016
View reviewed changes

aandis force-pushed the team-name-restrictions branch from 6b05dc3 to f7f1087 Compare March 9, 2016 16:07

aandis added the Review label Mar 9, 2016

aandis force-pushed the team-name-restrictions branch from f7f1087 to 8fa155e Compare March 10, 2016 18:03

aandis added 4 commits March 15, 2016 11:57

Added character restriction explaination. Closes #3880.

3f7692d

Added error message for invalid character in team name.

767a6ca

Added test for invalid character in team names.

34abe3a

Added slugize to team model. Fixes #3426.

47cfd17

chadwhitacre force-pushed the team-name-restrictions branch from 8fa155e to 0ef1a54 Compare March 15, 2016 15:58

chadwhitacre reviewed Mar 15, 2016
View reviewed changes

aandis and others added 5 commits March 15, 2016 13:42

Modified fake_data to use new slugize.

28ffee1

Alphabets -> Letters

0c0b9b0

Pep 8-ish whitespace between functions

2836263

Here's a test suite for slugize

c9a9050

Revise failure message

c444fe2

"23456789" technically does not contain invalid characters. ;-)

chadwhitacre force-pushed the team-name-restrictions branch from 48f9ae6 to c444fe2 Compare March 15, 2016 17:45

Fix test regressions

4063a7c

Added tests for new slugize.

2196bd6

chadwhitacre added a commit that referenced this pull request Mar 15, 2016

Merge pull request #3943 from gratipay/team-name-restrictions

169dc57

Team name restrictions

chadwhitacre merged commit 169dc57 into master Mar 15, 2016

chadwhitacre deleted the team-name-restrictions branch March 15, 2016 18:16

chadwhitacre added this to the Team Basics milestone Mar 15, 2016

chadwhitacre mentioned this pull request Mar 15, 2016

Radar 50 gratipay/inside.gratipay.com#539

Closed

aandis mentioned this pull request May 10, 2016

Core Radar 57 gratipay/inside.gratipay.com#596

Closed

aandis mentioned this pull request May 18, 2016

Changing team name does not auto-update slug/url #3871

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Team name restrictions #3943

Team name restrictions #3943

aandis commented Mar 6, 2016

aandis commented Mar 7, 2016

rohitpaulk Mar 7, 2016

aandis Mar 7, 2016

aandis Mar 8, 2016

mattbk commented Mar 7, 2016

mattbk commented Mar 7, 2016

mattbk commented Mar 8, 2016

mattbk commented Mar 8, 2016

rohitpaulk commented Mar 8, 2016

aandis commented Mar 8, 2016

mattbk commented Mar 8, 2016

aandis commented Mar 9, 2016

aandis commented Mar 10, 2016

mattbk commented Mar 14, 2016

chadwhitacre commented Mar 15, 2016

chadwhitacre commented Mar 15, 2016

chadwhitacre Mar 15, 2016

chadwhitacre Mar 15, 2016

aandis Mar 15, 2016

chadwhitacre Mar 15, 2016

chadwhitacre Mar 15, 2016

chadwhitacre commented Mar 15, 2016

chadwhitacre commented Mar 15, 2016

chadwhitacre commented Mar 15, 2016

aandis commented Mar 15, 2016

chadwhitacre commented Mar 15, 2016

aandis commented Mar 15, 2016

chadwhitacre commented Mar 15, 2016

aandis commented Mar 15, 2016

Team name restrictions #3943

Team name restrictions #3943

Conversation

aandis commented Mar 6, 2016

aandis commented Mar 7, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mattbk commented Mar 7, 2016

mattbk commented Mar 7, 2016

mattbk commented Mar 8, 2016

mattbk commented Mar 8, 2016

rohitpaulk commented Mar 8, 2016

aandis commented Mar 8, 2016

mattbk commented Mar 8, 2016

aandis commented Mar 9, 2016

aandis commented Mar 10, 2016

mattbk commented Mar 14, 2016

chadwhitacre commented Mar 15, 2016

chadwhitacre commented Mar 15, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chadwhitacre commented Mar 15, 2016

chadwhitacre commented Mar 15, 2016

chadwhitacre commented Mar 15, 2016

aandis commented Mar 15, 2016

chadwhitacre commented Mar 15, 2016

aandis commented Mar 15, 2016

chadwhitacre commented Mar 15, 2016

aandis commented Mar 15, 2016