Stub out Package model #4155

chadwhitacre · 2016-10-22T00:18:46Z

Just as the elsewhere table represents user accounts on other platforms, the packages table represents projects (Teams) that exist on open source package managers, starting with npm (#4153). In this PR we want to add the database and Python to be able to set up payments to packages. If the package is unclaimed then the payment instruction should be a pledge, not actually run during payday.

aandis · 2016-10-22T13:16:56Z

@whit537 linked teams to packages on the basis that Team has_one package and Package belongs_to a Team.

aandis · 2016-10-22T13:17:48Z

payments to packages.

would then be just adding payment_instruction for that team.

aandis · 2016-10-22T13:18:32Z

ca00824 is really untested. needs a good hard review. :)

chadwhitacre · 2016-10-22T13:25:31Z

Taking a look ...

chadwhitacre · 2016-10-22T13:29:11Z

gratipay/models/package/__init__.py

+from postgres.orm import Model
+
+class Package(Model):
+    """Represent a gratipackage. :-)


gratipackage

😀

chadwhitacre · 2016-10-22T13:33:40Z

sql/branch.sql

+    , long_description_raw  text                        NOT NULL DEFAULT ''
+    , long_description_type text                        NOT NULL DEFAULT ''
+    , team                  text                        REFERENCES teams
+                                                            ON UPDATE CASCADE ON DELETE RESTRICT


Let's use team_id linking to id rather than slug, so we don't make even more work for ourselves under #835.

chadwhitacre · 2016-12-02T22:01:33Z

@aandis Maybe dust this one off next?

aandis · 2016-12-04T16:14:37Z

I am thinking to scratch off all this boilerplate code for Package model because all upserts are done via the cli anyway. All we need is to link Team to Package and package_id inside teams does that.

aandis · 2016-12-04T16:26:53Z

package_id inside teams does that.

unless.. Team can have multiple packages?

aandis · 2016-12-04T16:35:24Z

unless.. Team can have multiple packages?

I think it's possible. Okay so let's just clean this up.

aandis · 2016-12-04T16:42:15Z

Deleted c50be1e and rebased on master. Previous head was 64c256b

aandis · 2016-12-04T17:58:57Z

Doubt if 2b5b1cc is needed, as we can handle it from the ui too. Apart from that what else is needed as part of this ticket @whit537? Is this good to go?

chadwhitacre · 2016-12-16T13:51:27Z

Rebased on master, was 2b5b1cc.

chadwhitacre · 2017-01-19T15:43:57Z

Rebased, was 48229ce.

chadwhitacre · 2017-02-07T22:13:41Z

Okay, I trimmed this up and am ready to see it merged.

@nobodxbodon @mattbk @JessaWitzel @aandis?

nobodxbodon · 2017-02-08T01:38:37Z

gratipay/models/package/__init__.py

+        """Return an existing package based on package manager and package names.
+        """
+        return cls.db.one("SELECT packages.*::packages FROM packages "
+                          "WHERE package_manager=%s and name=%s", (package_manager, name))


Is there plan to create table for package manager and reference its id in packages table?

Before making that change, shall we make 'npm' a constant shared across the app to avoid issue with raw string? Like using "Npm" by mistake, etc.

Or maybe, we use API from_name(cls, name) before adding support for other package managers?

Is there plan to create table for package manager and reference its id in packages table?

Not before May. We won't look at expanding beyond npm until later this year or possibly next.

Before making that change, shall we make 'npm' a constant shared across the app to avoid issue with raw string? Like using "Npm" by mistake, etc.

Like 9c05276?

Like 9c05276?

Yes. Not sure how helpful it would be though.

chadwhitacre · 2017-02-08T16:04:56Z

Anything else here, @nobodxbodon?

JessaWitzel · 2017-02-08T16:25:57Z

I can review late this afternoon.

nobodxbodon · 2017-02-08T16:54:12Z

@whit537 the rest LGTM. Thanks.

chadwhitacre · 2017-02-08T19:37:41Z

@JessaWitzel Cool, yours to merge if/when you're ready! :-)

mattbk · 2017-02-09T18:58:24Z

@JessaWitzel you can delete the branch now ;)

Includes: #4304 #4306 #4307 #4308 #4309 #4155 #4323

chadwhitacre added this to the Refocus on Corporate Sponsorship of Open Source milestone Oct 22, 2016

chadwhitacre mentioned this pull request Oct 22, 2016

Integrate npm #4148

Closed

23 tasks

chadwhitacre commented Oct 22, 2016

View reviewed changes

aandis mentioned this pull request Oct 22, 2016

Load up npm #4153

Merged

chadwhitacre force-pushed the projects-elsewhere branch from ca00824 to 64c256b Compare December 2, 2016 22:01

aandis force-pushed the projects-elsewhere branch from 64c256b to 804671e Compare December 4, 2016 16:41

aandis force-pushed the projects-elsewhere branch 2 times, most recently from 6a259a5 to 2b5b1cc Compare December 4, 2016 17:42

chadwhitacre force-pushed the projects-elsewhere branch from 2b5b1cc to 48229ce Compare December 16, 2016 13:51

chadwhitacre mentioned this pull request Jan 16, 2017

Spec out claim/unclaim/reclaim packages #4297

Closed

5 tasks

chadwhitacre force-pushed the projects-elsewhere branch from 48229ce to 477cfb7 Compare January 19, 2017 15:43

chadwhitacre mentioned this pull request Jan 24, 2017

Integrate initial package claiming PRs #4305

Merged

25 tasks

chadwhitacre changed the base branch from master to project/claim-packages January 24, 2017 22:04

chadwhitacre force-pushed the project/claim-packages branch from 37cc930 to d06e5f2 Compare January 24, 2017 22:39

aandis added 4 commits February 7, 2017 07:47

Add team reference to pacakges.

edfa226

Add package model init.

490adfa

Add Package model

be9dd15

Update insert columns. Cleanup

049e32f

chadwhitacre added 2 commits February 7, 2017 07:55

Add defaults to make_package in test harness

fb6f9a6

Clean up Package instantiation

9a53034

Prune stubbed out code

2b40ed0

chadwhitacre force-pushed the projects-elsewhere branch from 728a732 to 2b40ed0 Compare February 8, 2017 01:31

Smoke 'em if ya got 'em? :-)

a72e900

nobodxbodon reviewed Feb 8, 2017

View reviewed changes

chadwhitacre mentioned this pull request Feb 8, 2017

UI to send confirmation email for unclaimed packages #4309

Merged

Use constant instead of string literal for 'npm'

9c05276

chadwhitacre changed the title ~~Link packages to teams~~ Stub out Package model Feb 8, 2017

chadwhitacre added the Review label Feb 8, 2017

JessaWitzel approved these changes Feb 8, 2017

View reviewed changes

JessaWitzel merged commit c9338cf into project/claim-packages Feb 8, 2017

JessaWitzel deleted the projects-elsewhere branch February 9, 2017 19:58

chadwhitacre added a commit that referenced this pull request Feb 20, 2017

Checkpoint 1

bdd20ac

Includes: #4304 #4306 #4307 #4308 #4309 #4155 #4323

chadwhitacre added a commit that referenced this pull request Feb 20, 2017

Checkpoint 1

9ea1b0c

Includes: #4304 #4306 #4307 #4308 #4309 #4155 #4323

chadwhitacre added a commit that referenced this pull request Mar 3, 2017

Checkpoint 1

4ac1d86

Includes: #4304 #4306 #4307 #4308 #4309 #4155 #4323

chadwhitacre added a commit that referenced this pull request Mar 17, 2017

Checkpoint 1

11a436f

Includes: #4304 #4306 #4307 #4308 #4309 #4155 #4323

chadwhitacre added a commit that referenced this pull request Mar 25, 2017

Checkpoint 1

e17ea81

Includes: #4304 #4306 #4307 #4308 #4309 #4155 #4323

chadwhitacre added a commit that referenced this pull request Apr 3, 2017

Checkpoint 1

77d9094

Includes: #4304 #4306 #4307 #4308 #4309 #4155 #4323

chadwhitacre added a commit that referenced this pull request Apr 24, 2017

Checkpoint 1

fe6cc36

Includes: #4304 #4306 #4307 #4308 #4309 #4155 #4323

chadwhitacre added a commit that referenced this pull request Apr 28, 2017

Checkpoint 1

cf55953

Includes: #4304 #4306 #4307 #4308 #4309 #4155 #4323

chadwhitacre added a commit that referenced this pull request Apr 28, 2017

Checkpoint 1

3288ce2

Includes: #4304 #4306 #4307 #4308 #4309 #4155 #4323

chadwhitacre added a commit that referenced this pull request May 5, 2017

Checkpoint 1

758394c

Includes: #4304 #4306 #4307 #4308 #4309 #4155 #4323

chadwhitacre added a commit that referenced this pull request May 9, 2017

Checkpoint 1

18ab883

Includes: #4304 #4306 #4307 #4308 #4309 #4155 #4323

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stub out Package model #4155

Stub out Package model #4155

chadwhitacre commented Oct 22, 2016

aandis commented Oct 22, 2016

aandis commented Oct 22, 2016

aandis commented Oct 22, 2016

chadwhitacre commented Oct 22, 2016

chadwhitacre Oct 22, 2016

chadwhitacre Oct 22, 2016

kaguillera Oct 22, 2016

chadwhitacre commented Dec 2, 2016

aandis commented Dec 4, 2016

aandis commented Dec 4, 2016

aandis commented Dec 4, 2016

aandis commented Dec 4, 2016

aandis commented Dec 4, 2016

chadwhitacre commented Dec 16, 2016

chadwhitacre commented Jan 19, 2017

chadwhitacre commented Feb 7, 2017 •

edited

Loading

nobodxbodon Feb 8, 2017

chadwhitacre Feb 8, 2017

nobodxbodon Feb 8, 2017

chadwhitacre commented Feb 8, 2017

JessaWitzel commented Feb 8, 2017

nobodxbodon commented Feb 8, 2017

chadwhitacre commented Feb 8, 2017

mattbk commented Feb 9, 2017

Stub out Package model #4155

Stub out Package model #4155

Conversation

chadwhitacre commented Oct 22, 2016

aandis commented Oct 22, 2016

aandis commented Oct 22, 2016

aandis commented Oct 22, 2016

chadwhitacre commented Oct 22, 2016

chadwhitacre Oct 22, 2016

Choose a reason for hiding this comment

chadwhitacre Oct 22, 2016

Choose a reason for hiding this comment

kaguillera Oct 22, 2016

Choose a reason for hiding this comment

chadwhitacre commented Dec 2, 2016

aandis commented Dec 4, 2016

aandis commented Dec 4, 2016

aandis commented Dec 4, 2016

aandis commented Dec 4, 2016

aandis commented Dec 4, 2016

chadwhitacre commented Dec 16, 2016

chadwhitacre commented Jan 19, 2017

chadwhitacre commented Feb 7, 2017 • edited Loading

nobodxbodon Feb 8, 2017

Choose a reason for hiding this comment

chadwhitacre Feb 8, 2017

Choose a reason for hiding this comment

nobodxbodon Feb 8, 2017

Choose a reason for hiding this comment

chadwhitacre commented Feb 8, 2017

JessaWitzel commented Feb 8, 2017

nobodxbodon commented Feb 8, 2017

chadwhitacre commented Feb 8, 2017

mattbk commented Feb 9, 2017

chadwhitacre commented Feb 7, 2017 •

edited

Loading