-
Notifications
You must be signed in to change notification settings - Fork 308
Conversation
I'm going to stop the scheduled job and reprocess already-processed readmes before starting it up again. |
Let's get a sense of how long it will take to reprocess readmes ... |
Looks like scheduler tasks are not in |
Maybe if we remove and then re-add the addon? |
Hmm ... |
/me watches for a minute to see if the number changes ... |
It's not changing. I'm going to run a short scheduled job to see if it shows up in |
Alright, so I'm thinking we should split readme fetching and processing into two separate processes. We can use |
Actually, let's keep |
c67d598
to
99b8544
Compare
Alright, ready for review. cc: @rohitpaulk @aandis @nobodxbodon @kaguillera et al. |
What's up with this marky-markdown failure at Travis? Looks like its installing 9.0.1, which is also what I have locally. The tests pass for me locally. |
Drat. Does 9edf5b8 fail in the same way? |
No! |
Hmm ... now |
Hmm ... might actually be a type discrepancy, |
Ah, yeah, at some point this weird inline SVG snuck. O.o Now it's gone again? |
Oh! This is over in |
Here we go, let's try 9ec8a8b ... |
Yesssssss. 👍 Gonna clean up a few more things here ... |
39d1d07
to
05b5d36
Compare
- consolidate markdown tests in one place - rename render_like_npm for consistency - add some docstrings/futures/newlines
05b5d36
to
47daf81
Compare
At Travis and in production we still want to require YAJL, for performance, but we don't want to require that in local development. Note that we still skip the relevant tests if marky-markdown is not installed, so as to avoid introducing a Node dependency to local production. Unlike with ijson, which would silently degrade if local conditions were applied to production, a missing marky-markdown will hard-fail in production.
With this we have the potential to miss a marky-markdown misconfiguration at Travis, but not in production.
Okay! I think this is ready to go. What are the next steps once this is merged and deployed? What's our current state and how do we get to a database full of properly-rendered readmes to back #4151? |
We're using readme_needs_to_be_updated instead.
Heh. :) I started Okay! So I think the thing to do is to:
|
What about refetching? How do we schedule that? |
Oh right! |
Here we go! |
Part of #4148.