Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

Rename release.sh to deploy.sh #4202

Merged
merged 3 commits into from
Nov 24, 2016
Merged

Rename release.sh to deploy.sh #4202

merged 3 commits into from
Nov 24, 2016

Conversation

chadwhitacre
Copy link
Contributor

More accurate, no? Hopefully non-controversial. 🐭

@chadwhitacre
Copy link
Contributor Author

Ready for review @rohitpaulk @clone1018 @kaguillera @JessaWitzel et al.

@kaguillera
Copy link
Contributor

Simple enough but it needs rebasing.

@chadwhitacre
Copy link
Contributor Author

@kaguillera I think we are okay with using the "Update branch" button to merge instead of rebase?

@kaguillera
Copy link
Contributor

Fair enough, I was not sure how using the web based git would affect the code. I feel more secure with CLI

@chadwhitacre
Copy link
Contributor Author

Yeah, I actually prefer rebase as well. I just have an up-in-the-air state locally, deep in on #4205. :-)

Otoh, you have the power to checkout and rebase this PR branch! :)

@kaguillera
Copy link
Contributor

I was actually wondering about that because I think that I noticed that you have done that before

@kaguillera kaguillera merged commit 6379e68 into master Nov 24, 2016
@kaguillera kaguillera deleted the release-deploy branch November 24, 2016 04:52
@chadwhitacre
Copy link
Contributor Author

Yeah, just grab the branch name from the top under the title, then use that to git checkout release-deploy, do the rebase/force-push dance just like you would on one of your own PRs. Team PRs! :-)

screen shot 2016-11-23 at 11 53 16 pm

@kaguillera
Copy link
Contributor

Understood

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants