Start an Application object

[chadwhitacre]

This creates a new Application object that subsumes Website and should eventually eat all of wireup(!). Immediate next step is to make an Email mixin for it: #4346. We need to make this available to payday and models before we can work on email: #4350.

Todo

• change base to master

[chadwhitacre]

Stray log line.

[chadwhitacre]

Rebased, was 9d15411.

[chadwhitacre]

Okay! This PR is weighing in at +/-440 ... not as bad as I thought. :)

[chadwhitacre]

Erm, well, now up to 516. 😁

[chadwhitacre]

Rebased, was 24c1eb6.

[chadwhitacre]

This one is up next, @nobodxbodon et al.

[nobodxbodon]

Just did a very superficial review. No alarms found, just a general question: what's "cli" mean here?

[chadwhitacre]

"cli" means "command line interface"

Google search suggests that this is a common usage.

[nobodxbodon]

@whit537 thanks. I didn't realize the dequeue_emails/list_email_queue are command line tools. Now it makes sense. Would you like it to be reviewed more in depth by someone else or shall I merge it?

[chadwhitacre]

Yeah, we added those scripts a month or two ago when we wanted to send out a notification about our new terms of service (#4232).

Rebased again (was d39c8a3) to catch up with recent bugfix deploys. I'm ready to go here if you are, @nobodxbodon. Merge away as far as I'm concerned! :-)

[nobodxbodon]

I wonder how to restart travis manually? Or is it possible to config travis to retry automatically in case of timeout (no failed cases)?

[mattbk]

If you don't have whatever special privileges @whit537 has, one method is to make a small commit and push to jumpstart Travis again.

[chadwhitacre]

Yeah, there's a little "Restart build" button at upper right. Not sure why you don't have perms ...

[chadwhitacre]

[chadwhitacre]

Restarted ...

[chadwhitacre]

Green! :-)

[mattbk]

Yeah, there's a little "Restart build" button at upper right. Not sure why you don't have perms ...

On Travis itself? I don't have that.

[chadwhitacre]

After poking around for a bit in the Travis UI, the closest thing I found to something that might help us here is the "Sync" button for the Gratipay GitHub org. I've gone ahead and clicked that ... did that update perms sufficient to enable the "Restart build" button for yinz?

[mattbk]

Got it. I had to be signed into Travis using GitHub credentials. Before I always thought it was a button on the PR side. Didn't even know signing into Travis was a thing.

[chadwhitacre]

Ah! That makes sense. :-)

!m @mattbk

[chadwhitacre]

💃

[chadwhitacre]

This is confusing. I'm trying to deploy this and getting an error:

[gratipay] $ ./deploy.sh 
Already up-to-date.
Traceback (most recent call last):
  File "gratipay/wireup.py", line 11, in <module>
    import aspen
  File "/Users/whit537/personal/gratipay/gratipay.com/env/lib/python2.7/site-packages/aspen/__init__.py", line 65, in <module>
    import pkg_resources
  File "/Users/whit537/personal/gratipay/gratipay.com/env/lib/python2.7/site-packages/pkg_resources/__init__.py", line 37, in <module>
    import email.parser
  File "/Users/whit537/personal/gratipay/gratipay.com/gratipay/email.py", line 5, in <module>
    from aspen.simplates.pagination import parse_specline, split_and_escape
  File "/Users/whit537/personal/gratipay/gratipay.com/env/lib/python2.7/site-packages/aspen/simplates/__init__.py", line 15, in <module>
    from .. import log
ImportError: cannot import name log
[gratipay] $

[chadwhitacre]

[gratipay] $ git log | head -n1
commit 796d36e914a44b88e60964416e754c0b473ca163
[gratipay] $

[chadwhitacre]

I ran make clean env.

[chadwhitacre]

796d36e is indeed the merge of this PR into master:

https://github.com/gratipay/gratipay.com/commits/796d36e914a44b88e60964416e754c0b473ca163

[chadwhitacre]

Moving to #4364.