Fix export CSV bug (#4399) #4439
Conversation
rohitpaulk
force-pushed
the
fix-export-csv-bug
branch
from
8e96650 to
bf6bd4d
Compare
rohitpaulk
force-pushed
the
fix-export-csv-bug
branch
from
bf6bd4d to
7172922
Compare
|
Screenshot of docs:
|
This was an undocumented feature, we were always using mode=aggregate in links. Less to maintain, the better!
rohitpaulk
force-pushed
the
fix-export-csv-bug
branch
3 times, most recently
from
3da2b9a to
a6d3477
Compare
rohitpaulk
force-pushed
the
fix-export-csv-bug
branch
from
a6d3477 to
73e16c2
Compare
|
Looking good... going to perform a smoke test against the prod DB before marking as ready for review |
|
@rohitpaulk Does this relate to #4274? |
|
DB backup imported - I can replicate both issues (export csv returns empty, balances are wrong) using my own profile. Now to see if the patch fixes it... |
|
Blank export CSV is fixed! Balances still seem to be a problem though... |
Ah! I didn't run |
|
Balances lining up perfectly:
|
|
I'm seeing a small bug on the penultimate payday in 2016 though... It shows 2 masspay entries and a negative balance, where it should only be one.. |
|
Aha! Not a bug, we actually ran two masspays - gratipay/inside.gratipay.com#951 (comment) |
|
Okay! I think this is good to go. |
| DB Schema | ||
| --------- | ||
|
|
||
| is_suspipicous on participant can be None, True or False. It represents unknown, |
There was a problem hiding this comment.
THIS MAKES ME SO HAPPY TO FIX THIS TYPO!!!!!!!!!!!! 😻
|
👍 Works for me! |
|
Running!
|
|
Wrong ticket? 😜 |
|
Haha yes |
#4399 (Export as CSV yields blank file)
This is a regression from the move to Gratipay 2.0. We moved all internal money-moving logic to the
paymentstable instead oftransfers, but when history is fetched - only thetransferstable is hit.This affects the yearly balances calculation, exporting
givingand exportingtaking. I've solved the first 2 as part of this PR (since they are actually used in the UI right now). Added a note about fixingtaking- that can be a separate PR.