Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

Add a simple field to collect info re: projects #4641

Merged
merged 3 commits into from
Sep 20, 2017
Merged

Conversation

chadwhitacre
Copy link
Contributor

@chadwhitacre chadwhitacre commented Sep 19, 2017

One notch better than a note to email us. I think this is important to our pitch to companies, per gratipay/inside.gratipay.com#987 (comment).

@chadwhitacre
Copy link
Contributor Author

Ping @JessaWitzel @mattbk @dmk246 @rohitpaulk et al. for review!

@chadwhitacre
Copy link
Contributor Author

I have an email ready to send to Yahoo once this is deployed.

@mattbk
Copy link
Contributor

mattbk commented Sep 19, 2017

Eep! Mind looking over your info for us?

None of the fields is highlighted...

I'm getting this error irregularly.

@mattbk
Copy link
Contributor

mattbk commented Sep 19, 2017

I get that error for all values above $1999. I think this is reason for error above.

Also can't enter decimals, even .00.

@mattbk
Copy link
Contributor

mattbk commented Sep 20, 2017

I get that error for all values above $1999.

Same for master.

@mattbk
Copy link
Contributor

mattbk commented Sep 20, 2017

Just testing? Other than that it works for me and things show up in db.

- amount >= 2000 returns a failure result

@chadwhitacre
Copy link
Contributor Author

Yeah if you wire up a Braintree sandbox and turn the form on, then the CC form fields should highlight red when the amount is 2000+.

screen shot 2017-09-20 at 12 23 19 pm

@chadwhitacre
Copy link
Contributor Author

Actually, I maybe lied ...

@chadwhitacre
Copy link
Contributor Author

Alright, I see what you mean about the bad dollar amounts which simulate card charging problems not showing up with an error message in the UI. I don't think this PR introduces that problem though so can we reticket and proceed here?

@mattbk
Copy link
Contributor

mattbk commented Sep 20, 2017

Not a problem for me.

@mattbk mattbk merged commit ee8fa9f into master Sep 20, 2017
@mattbk mattbk deleted the grateful-field branch September 20, 2017 18:22
@chadwhitacre
Copy link
Contributor Author

Reticketed #4649.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants