-
Notifications
You must be signed in to change notification settings - Fork 19
Conversation
…r heroku-buildpack-static
Not ready yet! Doing work on the documentation now. |
|
||
``` | ||
git remote add prod grtp@grtp.co:production | ||
git remote add heroku https://git.heroku.com/grtp.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I normally prefer ssh key but this is Heroku recommended.
"headers": { | ||
"/**": { | ||
"Access-Control-Allow-Origin": "*", | ||
"Strict-Transport-Security": "max-age=31536000; includeSubdomains;" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These might be too general but I can't see any risk since the grtp domain is already so far removed. Plus the rule before was including any html, js and json
Ready to review! |
The heroku buildpack only saves the sources in |
What does "npm install" do exactly? Can we just add build step as:
Or it will fail as a recursive dependency? |
My point of confusion is that |
Well I'm definitely not a master. What can we do better and how should we improve this? |
I don't know yet. Let's fix tests first - #170 - and think about this later. P.S. I wish we had less vendor lockin, but going to Heroku is an awesome step compared to Nginx and SSH config before. |
This pull request is what we need to move grtp.co to Heroku, besides the actual inside-heroku setup.
The grtp.co Heroku setup is two buildpacks in a specific order:
And adding a
postinstall
ofmake build
. So really what's happening is heroku is installing nodejs for the build and then a simple nginx server serves up thewww/
directoryHere's a demo:
https://grtp.herokuapp.com/v2.js
Deployment is now
git push heroku master