Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

fix markdown regressions from switch to mistune #428

Closed
mattbk opened this issue Dec 4, 2015 · 6 comments
Closed

fix markdown regressions from switch to mistune #428

mattbk opened this issue Dec 4, 2015 · 6 comments

Comments

@mattbk
Copy link
Contributor

mattbk commented Dec 4, 2015

http://inside.gratipay.com/howto/build-gratipay

@chadwhitacre
Copy link
Contributor

:-(

I also noticed --- on http://inside.gratipay.com/big-picture/welcome not getting turned into (mdash).

It's something to do with a change in markdown renderer, I think.

@techtonik Weren't you involved with that? Do you remember what change we made?

@mattbk
Copy link
Contributor Author

mattbk commented Dec 23, 2015

As well as http://inside.gratipay.com/howto/tell-people-about-gratipay, but I imagine several pages have issues.

@chadwhitacre
Copy link
Contributor

For the --- the issue is that we never reimplemented SmartyPants when switching to mistune (#339; cf. lepture/mistune#57). Not sure about the HTML leakage ...

@chadwhitacre
Copy link
Contributor

@techtonik Are you able to work on this?

@chadwhitacre chadwhitacre changed the title howto/build-gratipay has some HTML leaking through fix markdown regressions from switch to mistune Feb 4, 2016
@chadwhitacre
Copy link
Contributor

https://pypi.python.org/pypi/smartypants/

Does it match what we were getting from Hoedown via misaka?

@techtonik
Copy link
Contributor

@whit537 sorry, I got ill - a week with temperature, and nerve in my right hand is aching so it is very painful to type. I hope that it will be better tomorrow. To catch things like this early we should add spider test like awesome-bot for links. Also I don't see where this build page is linked from through google info: query.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants