Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

Allow only GET/HEAD/POST #722

Merged
merged 5 commits into from
Jul 19, 2016
Merged

Allow only GET/HEAD/POST #722

merged 5 commits into from
Jul 19, 2016

Conversation

ghost
Copy link

@ghost ghost commented Jul 15, 2016

This aims to fix H1-117142.

Should we add tests for this?

@ghost
Copy link
Author

ghost commented Jul 15, 2016

(Writing the tests anyway since I never did this with aspen)

@chadwhitacre
Copy link
Contributor

Yay tests! 💃

Since we already have a .travis.yml (we're using Travis for deployment), how about modifying it to actually run the tests now that we have some? :-)

@ghost
Copy link
Author

ghost commented Jul 18, 2016

Let's see if everything works before trying to add cache.

@chadwhitacre
Copy link
Contributor

Skipping a deployment with the heroku provider because the current build is a pull request.

https://travis-ci.org/gratipay/inside.gratipay.com/builds/145687885#L241

👍

@chadwhitacre chadwhitacre merged commit e82054b into master Jul 19, 2016
@chadwhitacre chadwhitacre deleted the disable-verbs branch July 19, 2016 13:13
@ghost
Copy link
Author

ghost commented Aug 20, 2016

for allowed in ['GET', 'gEt', 'POST', 'HEAD']:
        response = client.hit('GET', trace='/')

Why ._____.

Fixing this.

@chadwhitacre
Copy link
Contributor

?

@ghost
Copy link
Author

ghost commented Aug 23, 2016

I'm always doing 'GET' request in the test, but 4 times, rather than trying the different allowed methods. I'll fix it while introducing new tests in #788.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant