Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versions, build on GitHub Actions #5

Merged
merged 7 commits into from
Nov 28, 2023

Conversation

camscale
Copy link

Update the Centos 8 Dockerfile so that it works as the yum archive has
been moved to vault.centos.org.

Add a new Debian 12 Dockerfile as the Debian 8 one no longer builds due
to the signing key of that Debian release having expired.

Pin fpm version in the Dockerfiles to 1.15.1.

Add a GitHub Actions workflow to build and push the centos8 and debian12
images, and remove the .drone.yml Drone config.

Issue: gravitational/teleport#20729

Update the Centos 8 Dockerfile so that it builds. Package archives for
Centos 8 have been moved to `vault.centos.org`, so update the yum config
to reflect this.

Also pin the version of fpm to the current latest - 1.15.1.
Add a Dockerfile to run fpm on Debian 12. The most recent Debian
Dockerfile in this repository is Debian 8 and that no longer builds as
the signing key for that Debian release has expired.

Also pin the version of fpm to the current latest - 1.15.1.
Move the building and publishing of the OCI images in this repository
from Drone to GitHub Actions. We are turning down Drone.
@camscale camscale marked this pull request as ready for review November 27, 2023 21:30
@wadells wadells self-requested a review November 27, 2023 23:08
Copy link

@wadells wadells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the overall approach here looks good. CentOS 8 as our RPM publishing platform makes sense given the options available.

.github/workflows/build.yaml Outdated Show resolved Hide resolved
.github/workflows/build.yaml Outdated Show resolved Hide resolved
debian/12/Dockerfile Show resolved Hide resolved
debian/12/Dockerfile Outdated Show resolved Hide resolved
.github/workflows/build.yaml Show resolved Hide resolved
@camscale camscale force-pushed the camh/move-to-github-actions branch from b37643e to 96d3027 Compare November 28, 2023 00:01
@camscale camscale force-pushed the camh/move-to-github-actions branch from 96d3027 to f5f78b3 Compare November 28, 2023 00:23
Docker labels/tags can contain only alphanumeric chars, underscores,
periods and hyphens and must start with alphanumeric or underscores. So
we convert all invalid chars to hyphens and strip leading invalid chars.
Also collapse runs of hyphens to a single hyphen.

Technically we do not need to strip the leading chars as we construct
the label with the version as a suffix, but it would look a little weird
if we didn't and allows us to use the version as a pure tag if we want
to later.
@camscale camscale force-pushed the camh/move-to-github-actions branch from 1d33e46 to 4dbb647 Compare November 28, 2023 01:22
@camscale
Copy link
Author

Running a test of the release-linux workflow that uses the latest images I've built with the current commit in this PR. Should be done shortly, which will verify if debian slim works fine.

@camscale
Copy link
Author

Works fine with debian slim.

@camscale camscale merged commit b778684 into master Nov 28, 2023
2 checks passed
@camscale camscale deleted the camh/move-to-github-actions branch November 28, 2023 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants