Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add govulncheck as a new linter #15

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Add govulncheck as a new linter #15

merged 1 commit into from
Sep 9, 2022

Conversation

reedloden
Copy link
Contributor

Run govulncheck in each directory containing go.mod.

References:

@reedloden reedloden requested a review from wadells September 9, 2022 04:50
@reedloden reedloden self-assigned this Sep 9, 2022
wadells
wadells reviewed Sep 9, 2022
View reviewed changes
Copy link
Contributor

@wadells wadells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you test this?

.github/workflows/govulncheck.yaml Outdated Show resolved Hide resolved
@reedloden
Copy link
Contributor Author

How did you test this?

The govulncheck section was tested manually using a clone of the teleport repo, emulating a fresh checkout.

➜  govulncheck.Klkf4EG1 for dir in $(find . -type f -name "go.mod" -exec dirname {} \;); do
  pushd $dir
  govulncheck ./...
  popd
done
/var/folders/nl/c14r87r51531yw29xjf7cc8w0000gn/T/govulncheck.Klkf4EG1/teleport /var/folders/nl/c14r87r51531yw29xjf7cc8w0000gn/T/govulncheck.Klkf4EG1 ~
govulncheck is an experimental tool. Share feedback at https://go.dev/s/govulncheck-feedback.

Scanning for dependencies with known vulnerabilities...
No vulnerabilities found.
/var/folders/nl/c14r87r51531yw29xjf7cc8w0000gn/T/govulncheck.Klkf4EG1 ~
/var/folders/nl/c14r87r51531yw29xjf7cc8w0000gn/T/govulncheck.Klkf4EG1/teleport/examples/go-client /var/folders/nl/c14r87r51531yw29xjf7cc8w0000gn/T/govulncheck.Klkf4EG1 ~
govulncheck is an experimental tool. Share feedback at https://go.dev/s/govulncheck-feedback.

Scanning for dependencies with known vulnerabilities...
No vulnerabilities found.
/var/folders/nl/c14r87r51531yw29xjf7cc8w0000gn/T/govulncheck.Klkf4EG1 ~
/var/folders/nl/c14r87r51531yw29xjf7cc8w0000gn/T/govulncheck.Klkf4EG1/teleport/examples/workflows /var/folders/nl/c14r87r51531yw29xjf7cc8w0000gn/T/govulncheck.Klkf4EG1 ~
govulncheck is an experimental tool. Share feedback at https://go.dev/s/govulncheck-feedback.

Scanning for dependencies with known vulnerabilities...
No vulnerabilities found.
/var/folders/nl/c14r87r51531yw29xjf7cc8w0000gn/T/govulncheck.Klkf4EG1 ~
/var/folders/nl/c14r87r51531yw29xjf7cc8w0000gn/T/govulncheck.Klkf4EG1/teleport/.github/workflows/robot /var/folders/nl/c14r87r51531yw29xjf7cc8w0000gn/T/govulncheck.Klkf4EG1 ~
govulncheck is an experimental tool. Share feedback at https://go.dev/s/govulncheck-feedback.

Scanning for dependencies with known vulnerabilities...
No vulnerabilities found.
/var/folders/nl/c14r87r51531yw29xjf7cc8w0000gn/T/govulncheck.Klkf4EG1 ~
/var/folders/nl/c14r87r51531yw29xjf7cc8w0000gn/T/govulncheck.Klkf4EG1/teleport/.cloudbuild/scripts /var/folders/nl/c14r87r51531yw29xjf7cc8w0000gn/T/govulncheck.Klkf4EG1 ~
govulncheck is an experimental tool. Share feedback at https://go.dev/s/govulncheck-feedback.

Scanning for dependencies with known vulnerabilities...
No vulnerabilities found.
/var/folders/nl/c14r87r51531yw29xjf7cc8w0000gn/T/govulncheck.Klkf4EG1 ~
/var/folders/nl/c14r87r51531yw29xjf7cc8w0000gn/T/govulncheck.Klkf4EG1/teleport/api /var/folders/nl/c14r87r51531yw29xjf7cc8w0000gn/T/govulncheck.Klkf4EG1 ~
govulncheck is an experimental tool. Share feedback at https://go.dev/s/govulncheck-feedback.

Scanning for dependencies with known vulnerabilities...
No vulnerabilities found.
/var/folders/nl/c14r87r51531yw29xjf7cc8w0000gn/T/govulncheck.Klkf4EG1 ~
/var/folders/nl/c14r87r51531yw29xjf7cc8w0000gn/T/govulncheck.Klkf4EG1/teleport/build.assets/tooling /var/folders/nl/c14r87r51531yw29xjf7cc8w0000gn/T/govulncheck.Klkf4EG1 ~
govulncheck is an experimental tool. Share feedback at https://go.dev/s/govulncheck-feedback.

Scanning for dependencies with known vulnerabilities...
No vulnerabilities found.
/var/folders/nl/c14r87r51531yw29xjf7cc8w0000gn/T/govulncheck.Klkf4EG1 ~
/var/folders/nl/c14r87r51531yw29xjf7cc8w0000gn/T/govulncheck.Klkf4EG1/teleport/assets/backport /var/folders/nl/c14r87r51531yw29xjf7cc8w0000gn/T/govulncheck.Klkf4EG1 ~
govulncheck is an experimental tool. Share feedback at https://go.dev/s/govulncheck-feedback.

Scanning for dependencies with known vulnerabilities...
No vulnerabilities found.
/var/folders/nl/c14r87r51531yw29xjf7cc8w0000gn/T/govulncheck.Klkf4EG1 ~

@reedloden
Add govulncheck as a new linter
245bae2 
Run `govulncheck` in each directory containing `go.mod`.

References:
* https://go.dev/blog/vuln
* https://vuln.go.dev/
* https://go.dev/security/vuln/
@reedloden reedloden merged commit 3660720 into main Sep 9, 2022
@reedloden reedloden deleted the reed/govulncheck branch September 9, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adaadb6 adaadb6 adaadb6 approved these changes

@wadells wadells wadells approved these changes

@russjones russjones Awaiting requested review from russjones

Assignees

@reedloden reedloden

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reedloden @wadells @adaadb6