Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit classify changes to Teleport repo #24

Merged
merged 1 commit into from
Oct 3, 2022
Merged

Limit classify changes to Teleport repo #24

merged 1 commit into from
Oct 3, 2022

Conversation

jimbishopp
Copy link
Contributor

The classifyChanges function determines whether a file path includes /docs and chooses different reviewers. This should only apply to the Teleport repo.

In order to support a repo comparison, the repo and teams constants were moved from the review package to the env package.

Copy link
Contributor

@r0mant r0mant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could've probably achieved the same without any code changes and just adding folks who should review docs to "docs reviewers" in the Cloud-specific json map? But lgtm either way.

@jimbishopp
Copy link
Contributor Author

@r0mant Thanks for reviewing. Docs in the cloud repo are internal runbooks and things - no need for different reviewers like in Teleport. For path-based reviewers, we're using the preferred reviewers functionality you created. I think this specific docs logic should be stripped out and Teleport should use preferred reviewers so we have one way to set reviewers based on path.

@jimbishopp jimbishopp merged commit 0306e5f into main Oct 3, 2022
@jimbishopp jimbishopp added the bug Something isn't working label Oct 3, 2022
@jimbishopp jimbishopp self-assigned this Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants