Fix an issue that prevents check from succeeding for external authors #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Go GitHub API that we use returns an error for repsonses with an HTTP status code not in the 200-299 range. This caused us to return an error rather than assume the user is an external author.
r0mant
approved these changes
Jan 26, 2023
wadells
approved these changes
Jan 26, 2023
jentfoo
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Go GitHub API that we use returns an error for repsonses with an HTTP status code not in the 200-299 range. This caused us to return an error rather than assume the user is an external author.
I noticed this when reviewing the logs of a recent run: https://github.com/gravitational/teleport/actions/runs/4018334113/jobs/6903826941