Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: fetch Github PR branch instead of head branch #90

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

r0mant
Copy link
Contributor

@r0mant r0mant commented Mar 17, 2023

Each Github pull request can be fetched locally using git fetch origin pull/<pr>/head. If we use this instead of fetch the user-defined PR branch in the backport bot, we should be able to re-enable the setting that automatically deletes branches for merged PRs.

I did a quick test locally and git fetch origin pull/<pr>/head seems to work fine even on merged PRs with the deleted user branch.

@r0mant r0mant requested review from a team March 17, 2023 23:43
Copy link
Contributor

@wadells wadells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

bot/internal/bot/backport.go Outdated Show resolved Hide resolved
@r0mant r0mant force-pushed the roman/fetch-pr-branch branch from 83df682 to 7dca51e Compare March 20, 2023 14:58
@r0mant r0mant merged commit 9281eba into main Mar 20, 2023
@r0mant r0mant deleted the roman/fetch-pr-branch branch March 20, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants