Update WebAuthn and U2F dependencies #16572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiaszheller
approved these changes
Sep 21, 2022
There was a problem hiding this comment.
LGTM,
i think when duo-labs/webauthn#150 it merged we can come back and bump webauthn lib
Let's see if it lands, definitely makes life easier. |
codingllama
force-pushed
the
codingllama/webauthn-update
branch
from
558c8e7 to
fe9f177
Compare
Joerger
approved these changes
Sep 21, 2022
codingllama
force-pushed
the
codingllama/webauthn-update
branch
from
fe9f177 to
14182c8
Compare
|
Friendly ping @jakule |
jakule
approved these changes
Sep 21, 2022
codingllama
force-pushed
the
codingllama/webauthn-update
branch
from
14182c8 to
cda1bc6
Compare
codingllama
force-pushed
the
codingllama/webauthn-update
branch
from
cda1bc6 to
a443731
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
duo-labs/webauthnup to20220122034320, which is the latest version we can get without dipping into dependency hell (etcdandopentelemetrywoes ensue after 2365c59d9f).tstranexcould be dropped for a while now (we moved on to WebAuthn-like interfaces for mocks).cfsslwas only imported due to what I assume was an IDE mishap.I've elected to keep
fxamacker/cbor, instead of trying to move to webauthncbor. fxamacker is solid, past v0, seems more appropriate for client-side libs and still backs webauthncbor.There are no updates for
flynn/hidandflynn/u2f.Release notes for fxamacker/cbor: https://github.com/fxamacker/cbor/releases/tag/v2.4.0.