fix(onboarding): run always hidden preset -> not erase progress

gravity-ui · Jul 2, 2024 · c449b8f · c449b8f
1 parent 0e2244f
commit c449b8f
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 2 deletions.
diff --git a/src/plugins/wizard-plugin.test.ts b/src/plugins/wizard-plugin.test.ts
@@ -176,6 +176,23 @@ describe('run preset', function () {
 
         expect(controller.state.progress?.presetPassedSteps.createProject).toBe(undefined);
     });
+
+    it('run always hidden preset -> NOT reset progress', async function () {
+        const options = getOptions();
+        options.plugins = [new WizardPlugin()];
+        // @ts-ignore
+        options.config.presets.createQueue.visibility = 'alwaysHidden';
+        const controller = new Controller(options);
+
+        await controller.stepElementReached({
+            stepSlug: 'createSprint',
+            element: getAnchorElement(),
+        });
+
+        await controller.runPreset('createQueue');
+
+        expect(controller.state.progress?.presetPassedSteps.createProject).not.toBe(undefined);
+    });
 });
 
 describe('finish preset', function () {

diff --git a/src/plugins/wizard-plugin.ts b/src/plugins/wizard-plugin.ts
@@ -48,14 +48,20 @@ export class WizardPlugin implements OnboardingPlugin {
         }
     };
 
-    onRunPreset = async () => {
+    onRunPreset = async ({preset}: EventsMap['runPreset']) => {
         if (!this.onboardingInstance) {
             return;
         }
 
         this.onboardingInstance?.closeHintByUser();
 
-        await this.eraseCommonPresetsProgress();
+        const currentPreset = this.onboardingInstance?.options.config.presets[preset];
+        const presetVisibility =
+            'visibility' in currentPreset ? currentPreset.visibility : undefined;
+
+        if (presetVisibility !== 'alwaysHidden') {
+            await this.eraseCommonPresetsProgress();
+        }
     };
 
     onFinishPreset = ({preset}: EventsMap['finishPreset']) => {