Expand orderBy argument schema to a list of maps #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljb7977
commented
Jul 24, 2022
| :id 100}}) | ||
| [:or [:> :price 10000] | ||
| [:and [:= :price 10000] [:or [:< :updated-at 1234] | ||
| [:and [:= :updated-at 1234] [:> :id 100]]]]]) |
There was a problem hiding this comment.
아직 작업중이라 남겨놨습니다 (나중엔 테스트 코드로 만들 예정이에요)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이 스레드에서 논의했던 것처럼 더 일반적인 정렬 옵션을 받을 수 있도록 orderBy argument의 타입을 확장합니다.
이를 사용하는 백엔드 코드 입장에서 하위호환이 깨지는 변화이기 때문에, 이 변경사항을 적용하는 PR도 신선하이 백엔드 쪽에 별도로 만들 예정입니다.