Decode-base64-encoded-vals #83
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jungwookim
requested review from
namenu,
devgrapher,
sookcha,
wickedev and
neverlish
namenu
reviewed
Dec 19, 2022
namenu
reviewed
Dec 19, 2022
|
@namenu 전부 다 반영해보았습니다! |
namenu
approved these changes
Dec 19, 2022
There was a problem hiding this comment.
지금도 충분하지만 사실 하고 싶은 얘기가 더 있었습니다!
multimethod 구현이 구체적인 타입에 의존하고 있는데, 그러다보면 사실 모든 경우를 커버하기가 근본적으로 불가능하여 놓치는 구현이 발생합니다. (예를 들어 set 이나 PersistentQueue 같은 자료구조가 들어올 수 있다거나)
인터페이스나 프로토콜에 따라 동작을 구현하면 이 빈틈이 메꾸어지는데요.
먼저 associative?로 reduce-kv 를 적용할 녀석을 거르고,
coll? 로 판단하여 시퀀스로 처리할 녀석을 거르고,
나머지(스칼라) 값들 중에서 문자열인 녀석을 거르면 좋지 않을까 합니다.
|
@namenu 좋은 자료네요! 감사드립니다. 언급하신 것 기반으로 재구현해보도록 하겠습니다! 지훈님의 원래 구현과 유사한 방향이군요. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:decode-base64-encoded-vals옵션을 추가했습니다.