Handle thrown exception and deliver lacinia result appropriately #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljb7977
commented
Apr 21, 2022
ljb7977
commented
Apr 21, 2022
| result)))) | ||
| (doall (map prom/resolve! promises result)))) | ||
| ;(run! (fn [[p result]] (prom/resolve! p result)) | ||
| ; (zipmap promises result)))) |
There was a problem hiding this comment.
사실 이건 원 저자가 만든 것처럼 run!을 써도 되는데, 그냥 doall~map이 맘에 더 들어서 바꿨습니다 ㅋㅋㅋ
(zipmap을 굳이 쓰는 게 별로기도 했구요)
run!이든 doall이든 둘 다 잘 동작하긴 합니다.
jungwookim
approved these changes
Apr 21, 2022
ljb7977
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.