promise 예외 캐치시 error로그를 남깁니다 #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devgrapher
commented
Jun 26, 2024
| (resolve/deliver! l-prom result)) | ||
| (fn [error] | ||
| (log/error "Error in promise!" error) | ||
| (resolve/deliver! l-prom nil {:message (.getMessage error)})) |
There was a problem hiding this comment.
예외 발생시에 prom/catch에 의해서 요 콜백으로 떨어지는데요,
resolve/deliver! 요걸 호출하다 또 예외가 나더군요.. ㅎㅎ
왜냐면 이미 then쪽에서 deliver!를 했고(resolve-promise의 status가 바꼈고) callback을 호출하다가 터지는 상황인데,
deliver!를 또하면 중복호출이라고 또 다른 예외가 나게되어있습니다. 그렇다고 이걸 지울수도 없고..
namenu
approved these changes
Jun 26, 2024
|
#2 이거랑 같은 증상일 수도 있겠군요. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/green-labs/farmmorning-backend/pull/6656 이 이슈 상황에서 15초 타임아웃을 해결해보려고 했는데요,
해결방법을 찾기 전에 일단 로그라도 남깁니다.