Get greenkeeper-lockfile working for Jenkins pipelines. #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janl
requested changes
Oct 18, 2017
There was a problem hiding this comment.
@chrisleck looks good overall, just two minor comments on the code.
| module.exports = { | ||
| gitUrl: env.GIT_URL, | ||
| branchName: _.drop(_.split(env.GIT_BRANCH, '/')).join('/'), |
There was a problem hiding this comment.
The branchName mangling code seems to not have survived this. Any particular reason?
| @@ -3,10 +3,18 @@ const env = process.env | |||
| const _ = require('lodash') | |||
There was a problem hiding this comment.
Leftover lodash require, either remove, or address my other comment for old line 8.
This was referenced Oct 18, 2017
Closed
This was referenced Apr 23, 2018
Merged
|
I pulled down these changes and addressed code review - put in a new PR at #148 as couldn't push to this branch |
|
closing because #148 is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #68.