-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLANET-7656 Prepare for WordPress 6.7 upgrade #2472
Conversation
/unhold 81b5b5f7-bc79-4e95-ab06-1093968a6eff
Test instance is ready 🚀🌑 janus | admin | blocks report | CircleCI | composer-local.json ⌚ 2024.12.17 17:06:59 |
/unhold 68e5c7bf-108c-4b00-8c79-3348777dd335
/unhold 9ac716f3-801d-4010-b63d-ba9a2dd2bd39
/unhold 4124c00e-2bd2-462d-be0d-b57527b74da2
/unhold 9071e117-767e-4ca8-832b-11c5526afa89
/unhold 9249692c-8671-4acd-afab-616a52b85722
/unhold dbe6e2a9-10d1-4ea7-b9b3-ad885eb85f06
From the findings list, one thing we should probably fix is the "how many items to display" on our QLB variations. As we offer that option on Covers and Articles, editors may look for that option in these two new blocks too. If you think it requires a bigger amount of work we can fix that in a follow up ticket. |
The core Posts List variation of the Query Loop block has been removed so we don't need to unregister it anymore
Some of these were broken by the WP upgrade to 6.7
/unhold a96b89a9-1b30-4e36-806b-0354aed7dea3
These could be needed by the community
@comzeradd I've updated the PR and it should work now! However I think that we should set a |
/unhold 0d0fba96-55d9-4621-aad9-03a95ed89b04
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
Description
See PLANET-7656
Related PRs:
Changes made for the upgrade:
allowedControls
.Things I noticed but don't need changes or I'm not sure they are problematic:
sizes=”auto”
for lazy-loaded images (see here), I haven't seen it happen for our blocks though, maybe because we add our ownsizes
attribute?Testing
You can update your local to the latest WordPress version (6.7.1) by running
npx wp-env run cli wp core update
. The janus test instance used for this PR has already been updated.