Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLANET-7656 Prepare for WordPress 6.7 upgrade #2472

Merged
merged 3 commits into from
Dec 18, 2024
Merged

PLANET-7656 Prepare for WordPress 6.7 upgrade #2472

merged 3 commits into from
Dec 18, 2024

Conversation

mleray
Copy link
Contributor

@mleray mleray commented Dec 10, 2024

Description

See PLANET-7656

Related PRs:

Changes made for the upgrade:

  • The core Posts List variation of the Query Loop block has been removed so we don't need to unregister it anymore
  • Some e2e tests were failing
  • The Posts List and Actions List block no longer had the controls to set how many items to display, the offset and max number of pages... These have been moved to the sidebar and we need to add them to the allowedControls.

Things I noticed but don't need changes or I'm not sure they are problematic:

  • WordPress 6.7 adds sizes=”auto” for lazy-loaded images (see here), I haven't seen it happen for our blocks though, maybe because we add our own sizes attribute?
  • There is a new setting in the editor preferences to hide the starter modal with our patterns, maybe some NROs don't use them and would be interested in this?
  • We should be able to close this bug ticket after the upgrade (see comments there)

Testing

You can update your local to the latest WordPress version (6.7.1) by running npx wp-env run cli wp core update. The janus test instance used for this PR has already been updated.

@mleray mleray self-assigned this Dec 10, 2024
planet-4 added a commit to greenpeace/planet4-test-janus that referenced this pull request Dec 10, 2024
/unhold 81b5b5f7-bc79-4e95-ab06-1093968a6eff
@planet-4
Copy link
Contributor

planet-4 commented Dec 10, 2024

Test instance is ready 🚀

🌑 janus | admin | blocks report | CircleCI | composer-local.json

⌚ 2024.12.17 17:06:59

planet-4 added a commit to greenpeace/planet4-test-janus that referenced this pull request Dec 10, 2024
/unhold 68e5c7bf-108c-4b00-8c79-3348777dd335
planet-4 added a commit to greenpeace/planet4-test-janus that referenced this pull request Dec 11, 2024
/unhold 9ac716f3-801d-4010-b63d-ba9a2dd2bd39
planet-4 added a commit to greenpeace/planet4-test-janus that referenced this pull request Dec 11, 2024
/unhold 4124c00e-2bd2-462d-be0d-b57527b74da2
planet-4 added a commit to greenpeace/planet4-test-janus that referenced this pull request Dec 11, 2024
/unhold 9071e117-767e-4ca8-832b-11c5526afa89
planet-4 added a commit to greenpeace/planet4-test-janus that referenced this pull request Dec 11, 2024
/unhold 9249692c-8671-4acd-afab-616a52b85722
@mleray mleray added the Review label Dec 11, 2024
@mleray mleray requested a review from comzeradd December 11, 2024 14:00
@mleray mleray marked this pull request as ready for review December 11, 2024 14:04
planet-4 added a commit to greenpeace/planet4-test-janus that referenced this pull request Dec 11, 2024
/unhold dbe6e2a9-10d1-4ea7-b9b3-ad885eb85f06
@comzeradd
Copy link
Member

From the findings list, one thing we should probably fix is the "how many items to display" on our QLB variations. As we offer that option on Covers and Articles, editors may look for that option in these two new blocks too. If you think it requires a bigger amount of work we can fix that in a follow up ticket.

The core Posts List variation of the Query Loop block has been removed so we don't need to unregister it anymore
Some of these were broken by the WP upgrade to 6.7
planet-4 added a commit to greenpeace/planet4-test-janus that referenced this pull request Dec 16, 2024
/unhold a96b89a9-1b30-4e36-806b-0354aed7dea3
@mleray
Copy link
Contributor Author

mleray commented Dec 17, 2024

From the findings list, one thing we should probably fix is the "how many items to display" on our QLB variations. As we offer that option on Covers and Articles, editors may look for that option in these two new blocks too. If you think it requires a bigger amount of work we can fix that in a follow up ticket.

@comzeradd I've updated the PR and it should work now! However I think that we should set a min and max, because currently it's from 1 to 100, what do you think?

planet-4 added a commit to greenpeace/planet4-test-janus that referenced this pull request Dec 17, 2024
/unhold 0d0fba96-55d9-4621-aad9-03a95ed89b04
Copy link
Member

@comzeradd comzeradd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mleray mleray merged commit 7fe3e28 into main Dec 18, 2024
15 checks passed
@mleray mleray deleted the wp6.7 branch December 18, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants