-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLANET-7153: Follow up Wordpress 6.2 deprecations #1042
Conversation
a9df172
to
8d7fe53
Compare
/unhold 6e3a3093-9ad0-44d3-b10f-9b4c838dd60f
Test instance is ready 🚀🌑 rhea | admin | blocks report | CircleCI | composer-local.json ⌚ 2023.08.23 13:28:51 |
4f27fec
to
d803524
Compare
/unhold 55642627-cee0-424b-b3ab-a0531d5c29f4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we include the changes from this PR into this one? 🤔
TBH, I don't believe these changes are 100% related to #1039, but yes to greenpeace/planet4-base#244 |
/unhold 249cbd77-8821-418c-8ad5-befb38057b6b
/unhold 56dbefbd-73ea-4314-8f9d-00eacbe897cf
/unhold f6473d6a-d38d-49bf-919b-7b230d213755
/unhold 77aec18b-0492-4aa8-be7d-09eeb8a3e7a4
fde8a7c
to
51401b5
Compare
/unhold e366f99f-d0fe-4fa7-8168-e571ffdbed40
51401b5
to
65af8cd
Compare
/unhold 296c15bb-ce10-4226-8288-c5a8975a4d5b
/unhold 802e00db-3f0f-43c0-b958-58a4b9da998b
65af8cd
to
8a4e973
Compare
/unhold 41eed0c6-1de4-4826-9e04-d26ce7739beb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
/unhold 51822917-14f3-429b-bbcb-e25fdc42c25d
/unhold b344c9a8-64e7-4e32-8480-cd2c5ac21b2b
/unhold e89565af-bd8d-4a9c-8a58-848a3d0c2442
8a4e973
to
e4be0ff
Compare
/unhold ab451588-484e-4733-a6ec-9c4fb968d9f5
/unhold 95ab46db-e8df-4f82-9c1a-8e071c21172e
/unhold d10123a3-133d-4994-8e5d-ae1650ab8a9f
- Taken from @types/wordpress__components/button/index.d.ts line 15
- Taken from @types/wordpress__components/button/index.d.ts line 21
- ReactDOM.hydrate is no longer supported in React 18
e4be0ff
to
33f5d88
Compare
/unhold 2d31e0b6-fafc-4d36-9bb3-92eb262cc0b5
/unhold c1777307-ba12-4b36-830f-1ff36a853719
Ref: https://jira.greenpeace.org/browse/PLANET-7153
Description
Since we're about to upgrade to WordPress 6.2 “Dolphy” we would need to make sure our code is up to date with the new requirements. Some of them has been deprecated since WordPress 6.1 “Misha”.
The current PR should be merged after
Testing
Make sure to run
Wordpress 6.2
on your local.