Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(View only 1/2) Add new feature register - "Register scene to grida app" #120

Merged
merged 38 commits into from
Aug 13, 2021
Merged

(View only 1/2) Add new feature register - "Register scene to grida app" #120

merged 38 commits into from
Aug 13, 2021

Conversation

softmarshmallow
Copy link
Member

@softmarshmallow softmarshmallow commented Aug 4, 2021 •
edited
Loading

WIP Feature
image
image

Major internal logic changes

  • the value of ASSISTANT_PLUGIN_NAMESPACE has been updated.
// from
export const ASSISTANT_PLUGIN_NAMESPACE = "zyx.bridged.assistant"
// to
export const ASSISTANT_PLUGIN_NAMESPACE__NOCHANGE = "co.grida.assistant";

@CLAassistant
Copy link

CLAassistant commented Aug 11, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

You-J and others added 18 commits August 11, 2021 21:25
@You-J
stash add : code screen contorl
365a660
@softmarshmallow
[fix] remove missing files imports & references
be86bba
@softmarshmallow
fix: change initial preset to flutter_default
96e1bdf
@softmarshmallow
update empty state placeholder text logic
6d6e359
@softmarshmallow
update source maker logic
36fe54a
@You-J
stash add: button style
d9c279c
@You-J
Merge branch 'feature/register-scene' of https://github.com/gridaco/a…
ffd3dc5 
…ssistant into feature/register-scene
@You-J
add: set button style
7630c15
@You-J
add: Docstring wrapper style
cf73b31
@softmarshmallow
add remote formatting support for jsx & add advanced formatter support
c8ba28f
@You-J
stash add: upload-step
b7b63b1
@You-J
Merge branch 'feature/register-scene' of https://github.com/gridaco/a…
9692935 
…ssistant into feature/register-scene
@You-J
stash add: code-screen display none
88e4cae
@You-J
fix white button style
5af089c
@softmarshmallow
change tabbar not to be scrollable - since now support resizing
ec48aac
@You-J
add: progress bar
9b8b957
@You-J
Merge branch 'feature/register-scene' of https://github.com/gridaco/a…
81dfaa2 
…ssistant into feature/register-scene
@You-J
add: check icon animation
0895ee2
@softmarshmallow softmarshmallow changed the base branch from main to staging August 13, 2021 08:13
@softmarshmallow
Copy link
Member Author

Changed target branch to staging

@softmarshmallow softmarshmallow changed the title Add new feature register - "Register scene to grida app" (View only 1/2) Add new feature register - "Register scene to grida app" Aug 13, 2021
@softmarshmallow softmarshmallow marked this pull request as ready for review August 13, 2021 15:01
@softmarshmallow softmarshmallow merged commit 9d8a140 into staging Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@softmarshmallow softmarshmallow

@You-J You-J

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@softmarshmallow @CLAassistant @You-J