mandatory, voting: Implement poll type validation in protocol

[jamescowens]

This PR implements poll type validation for poll submission and receipt in protocol. It also implements the display of AVW validation in both RPC and the GUI, fixes the poll ending height by time problem discussed in #2407, and addresses a number of subtle bugs I discovered along the way.

Closes #1788.
Closes #2407.

[iFoggz]

i like where this is going.

[jamescowens]

Ok. This is pretty much everything except for the AVW validation. That is going to require some thought and also has to deal with #2407. I will work on that this weekend.

[jamescowens]

The only thing left on this is the specific issue raised in #2407. I will think about this over the next day.

[jamescowens]

This has now been fully tested on a fork with four nodes past a set pollv3height threshold to test out v3 functionality. As a result of the testing a number of adjustments were made. I have also implemented a poll type label which shows up opposite the poll title for v3+ polls and is also a column in the tabular view. This is suppressed for < v3 polls because all polls are type survey less than v3.

[jamescowens]

You can see here that v3 polls have the "validated" moniker as soon as they have reached the AVW % threshold required by the poll type rule. They also have the poll type label. There is one older v2 poll listed there that does not.

The moniker or tag for validation has three states:

1. Blank for v2 polls or v3 polls that have not reached vote weight % AVW threshold for validation and have not expired (are still active)
2. Green "Validated" for v3 polls that have reached vote weight % AVW threshold for validation. This will appear immediately when that has been reached, regardless of whether the poll is expired or not.
3. Red "Invalid" for v3 polls that have expired and failed to reach the vote weight % AVW threshold.

[jamescowens]

Test of creation of projects poll with required fields:

16:11:06
addpoll project "Dummy Project 1 whitelist request" 21 "Should we whitelist this project?" "" 2 1 "http://gridcoin.us" "project_name=Dummy Project 1;project_url=https://dummy1.com"

16:11:06
{
"title": "Dummy Project 1 whitelist request",
"id": "723053b76b4fe40c8ee44ed013dcb62bbd2226da67d0555e2593c0896753da74",
"question": "Should we whitelist this project?",
"url": "http://gridcoin.us",
"additional_fields": [
{
"project_name": {
"value": "Dummy Project 1",
"required": true
}
},
{
"project_url": {
"value": "https://dummy1.com",
"required": true
}
}
],
"poll_type": "Project Listing",
"poll_type_id": 2,
"weight_type": "Magnitude+Balance",
"weight_type_id": 3,
"response_type": "Yes/No/Abstain",
"response_type_id": 1,
"duration_days": 21,
"expiration": "07-04-2022 20:11:06",
"timestamp": "06-13-2022 20:11:06",
"choices": [
{
"id": 0,
"label": "Yes"
},
{
"id": 1,
"label": "No"
},
{
"id": 2,
"label": "Abstain"
}
]
}

16:15:37
listpolls

16:15:37
[
{
"title": "Dummy Project 1 whitelist request",
"id": "723053b76b4fe40c8ee44ed013dcb62bbd2226da67d0555e2593c0896753da74",
"question": "Should we whitelist this project?",
"url": "http://gridcoin.us",
"additional_fields": [
{
"project_name": {
"value": "Dummy Project 1",
"required": true
}
},
{
"project_url": {
"value": "https://dummy1.com",
"required": true
}
}
],
"poll_type": "Project Listing",
"poll_type_id": 2,
"weight_type": "Magnitude+Balance",
"weight_type_id": 3,
"response_type": "Yes/No/Abstain",
"response_type_id": 1,
"duration_days": 21,
"expiration": "07-04-2022 20:11:06",
"timestamp": "06-13-2022 20:11:06",
"choices": [
{
"id": 0,
"label": "Yes"
},
{
"id": 1,
"label": "No"
},
{
"id": 2,
"label": "Abstain"
}
],
"votes": 0
},
{
"title": "Testnet build frequency",
"id": "996896739981aca390d0f06aa05422292aa8510778f10295897e72f9e33a5a49",
"question": "Are testnet builds frequent enough?",
"url": "http://gridcoin.us",
"additional_fields": [
],
"poll_type": "Community",
"poll_type_id": 7,
"weight_type": "Magnitude+Balance",
"weight_type_id": 3,
"response_type": "Yes/No/Abstain",
"response_type_id": 1,
"duration_days": 21,
"expiration": "07-03-2022 06:04:05",
"timestamp": "06-12-2022 06:04:05",
"choices": [
{
"id": 0,
"label": "Yes"
},
{
"id": 1,
"label": "No"
},
{
"id": 2,
"label": "Abstain"
}
],
"votes": 4
},
{
"title": "Testnet build quality",
"id": "ccf94e0120c9ca67b45560d726e6c17b944b71d86da62177167ba25c31494483",
"question": "Are the testnet builds at a sufficiently polished level?",
"url": "http://gridcoin.us",
"additional_fields": [
],
"poll_type": "Community",
"poll_type_id": 7,
"weight_type": "Magnitude+Balance",
"weight_type_id": 3,
"response_type": "Yes/No/Abstain",
"response_type_id": 1,
"duration_days": 21,
"expiration": "07-03-2022 06:10:38",
"timestamp": "06-12-2022 06:10:38",
"choices": [
{
"id": 0,
"label": "Yes"
},
{
"id": 1,
"label": "No"
},
{
"id": 2,
"label": "Abstain"
}
],
"votes": 4
},
{
"title": "Testnet participation",
"id": "31d6e2bbbb7f7f98dac152fc8338440139ff587e4f1b683522b9887d1e2b41f2",
"question": "Are there enough testnet participants?",
"url": "http://gridcoin.us",
"additional_fields": [
],
"poll_type": "Survey",
"poll_type_id": 1,
"weight_type": "Magnitude+Balance",
"weight_type_id": 3,
"response_type": "Yes/No/Abstain",
"response_type_id": 1,
"duration_days": 21,
"expiration": "06-25-2022 08:25:44",
"timestamp": "06-04-2022 08:25:44",
"choices": [
{
"id": 0,
"label": "Yes"
},
{
"id": 1,
"label": "No"
},
{
"id": 2,
"label": "Abstain"
}
],
"votes": 6
}
]

[jamescowens]

[jamescowens]

Now I have to create an additional fields model and table view to be able to deal with these in the GUI.

[jamescowens]

@div72 I want to cut this off and get this into testnet. I will do the GUI part for the additional fields, which is not consensus critical, in a separate PR.

[jamescowens]

After you approve, I will add one more commit for the testnet blockheight where v3 polls are going to go live.

[div72]

Looks pretty good otherwise. I'll commence testing.

[jamescowens]

@div72 Please give this one last look. I think it is ready to merge. Then I will rebase #2525 and we will get the GUI part out.