util: Diagnose Lib Version #1 #2573

MinaFarhan · 2022-09-09T05:23:26Z

Closes #2477.

MinaFarhan · 2022-09-09T05:24:41Z

Create a library for Diagnose so it can be called by the RPC.

Pythonix · 2022-09-09T13:08:37Z

Looks like a great addition! I will pay a bounty of 1000 GRC to @MinaFarhan once this gets merged =)
Once the RPC commands are added it probably closes #2477?

iFoggz · 2022-09-10T06:13:16Z

Great to have a RPC of diagnostics,

there is some coding changes that should be done to comply with: coding.txt as per the CONTRIBUTING.md.

Once it's cleaned up I'll have a gander through as well as the other devs.

Look forward to this feature to be added.

iFoggz · 2022-09-10T06:14:10Z

Also should note that I'd like to see RPC diagnostics available for daemon as well.

jamescowens · 2022-09-11T15:55:49Z

@iFoggz He has been looking to volunteer and asked me a while back what would be a good way to get started. I suggested a smaller scale task at first, but one which would introduce him to parts of the code and not be too difficult. We settled on a split-out of the diagnostics into a service API as his first contribution. He looks to build the rpc calls as the next step.

src/Makefile.qt.include

jamescowens

This is a nice starting point. @iFoggz is right about some of the style elements. Please use the Bitcoin Core coding guide as our own contribution guide is a little out of date. Note that the VerifyTCPPort and VerifyClock functions are still using Qt plumbing. This will not work for the daemon, because Qt dependencies should not be used there. (I warned you about this, and this will be the hardest part, because you are going to have to use basic networking without the benefit of the Qt superstructure.)

jamescowens · 2022-09-11T18:26:42Z

Also, I have authorized your PR to do CI. Please review which build is failing and correct the cause.

MinaFarhan · 2022-09-11T23:46:20Z

Looks like a great addition! I will pay a bounty of 1000 GRC to @MinaFarhan once this gets merged =) Once the RPC commands are added it probably closes #2477?

Thank you.

MinaFarhan · 2022-09-11T23:48:18Z

This is a nice starting point. @iFoggz is right about some of the style elements. Please use the Bitcoin Core coding guide as our own contribution guide is a little out of date. Note that the VerifyTCPPort and VerifyClock functions are still using Qt plumbing. This will not work for the daemon, because Qt dependencies should not be used there. (I warned you about this, and this will be the hardest part, because you are going to have to use basic networking without the benefit of the Qt superstructure.)

I am thinking of calling the QApplication() from the library. This way even if the library is called from the daemon, we can initialte the Qapplication and call the QT functions , like QTimer(). What do you think?

jamescowens · 2022-09-13T17:00:04Z

I don't think it is going to work, because Qt is not linked into the daemon, and it is not a good idea to try and call Qt stuff in the core. The native core has scheduling functionality. The existing global scheduler (static CScheduler scheduler) can be used to initiate a "timeout" interval in the core instead of the QTimer for example. See schedule() or scheduleFromNow() in scheduler.h/cpp

MinaFarhan · 2022-09-14T05:03:39Z

Sounds Good!
I will change the QT functions with May be boost libraries. QTimer for example can be changed with boost deadline_timer.

MinaFarhan · 2022-09-19T05:05:40Z

Changed file names to use lower cases
Replaced the QT functions (ex QTimer) with boost library functions
Fixed the compilation error.
Next, I need to fix the code comments to match the Bitcoin standard.

src/qt/diagnose.h

src/qt/diagnosticsdialog.cpp

MinaFarhan · 2022-10-01T08:12:33Z

I have committed new code

changed the QT functions to the equivalent boost library so the library can be called outside UI from RPC
Cleaned the code and removed commented out functions
fixed typos in the code comment

jamescowens · 2022-10-04T14:35:31Z

@MinaFarhan please review the logs for CI and correct issues and get the code to compile cleanly on all architectures and pass the linter.

MinaFarhan · 2022-10-04T14:54:42Z

@MinaFarhan please review the logs for CI and correct issues and get the code to compile cleanly on all architectures and pass the linter.

Yes, I am actually working on adding the RPC to the seam on as well. This requires some changes . Will submit all fixes together

MinaFarhan · 2022-10-08T07:43:14Z

I have added rpc command "walletdiagnose",
I also fixed some compiling warnings and errors.

jamescowens

Nitpicking stuff, but you need to correct the code style stuff so the linter passes. There are also still some misspellings too. Please go through with a fine tooth comb. I may not have caught them all in the review. Once the code passes the CI and linter, then I will go through a more detailed pass.

src/Makefile.am

src/qt/diagnosticsdialog.cpp

jamescowens · 2022-10-09T00:54:45Z

@MinaFarhan don't get discouraged by the "nitpicking" reviews. You will quickly get used to writing code that passes the spelling and code style stuff. The linter and CI is your friend in many ways in this regard. After your first PR, the CI will run automatically when you push a branch to github to allow you to check. You can also run the linter locally on your development workstation if you have all of the required packages installed. (This is a superset of the normal build packages.)

MinaFarhan · 2022-10-10T05:29:30Z

No problem :)
I will make the corrections and resubmit.

This commit should be removed before merge to development.

jamescowens · 2022-10-23T18:45:42Z

@MinaFarhan I did a PR to your branch. Please take a look at the commits. Note that while it passes compile now, There are some problems in operation that you need to troubleshoot related to the boost:asio.

src/wallet/rpcwallet.cpp

src/wallet/diagnose.h

jamescowens · 2022-10-23T18:47:43Z

@MinaFarhan after you merge my PR to your branch, you should rebase your branch on top of the head of development before pushing back here, because the root of your PR is behind development a bit at this point. Thanks.

util: Implement core diagnostics

jamescowens · 2022-10-24T06:26:43Z

@MinaFarhan you should really do a rebase on top of development with your branch rather than a merge, because a merge will generate an extra merge commit that I have to filter out later in the change log.

Something like
git checkout DiagnoseLib
git reset --hard caaf952 (This is the merge of my PR to your branch.)
git checkout development
git pull
git checkout DiagnoseLib
git rebase development
git push

In general the rule is that all branches that are the source of PR's (which means the PR's themselves) should always be rebased to "advance" them to include any new commits on the base branch, while PRs should always be merged by the maintainer onto the target branch.

jamescowens · 2022-10-24T06:30:09Z

We still need to troubleshoot the crashes on that bus error in boost asio.

MinaFarhan · 2022-10-25T03:48:17Z

We still need to troubleshoot the crashes on that bus error in boost asio.

Yes, working on it.

MinaFarhan · 2022-10-25T03:49:19Z

@MinaFarhan you should really do a rebase on top of development with your branch rather than a merge, because a merge will generate an extra merge commit that I have to filter out later in the change log.

Something like git checkout DiagnoseLib git reset --hard caaf952 (This is the merge of my PR to your branch.) git checkout development git pull git checkout DiagnoseLib git rebase development git push

In general the rule is that all branches that are the source of PR's (which means the PR's themselves) should always be rebased to "advance" them to include any new commits on the base branch, while PRs should always be merged by the maintainer onto the target branch.

Ohh, sure I can do that next time. Do I still need to rebase instead of merge or is it too late?

MinaFarhan · 2022-10-25T14:49:59Z

We still need to troubleshoot the crashes on that bus error in boost asio.

Yes, working on it.

Hello
L
I can not reproduce the issue on my PC. What version of Linux you are using? And is it a random issue or always appear when diagnostics are run?
thank you

jamescowens · 2022-10-25T18:41:43Z

Always. openSuSE Leap 15.4, which has boost 1.66.0.

jamescowens · 2022-10-25T18:43:06Z

Note that from my particular public IP, the default time service we use does not respond in a timely manner. You should simulate a non-responsive URL for the time server and see if you can reproduce the crash that way. That is the likely culprit.

MinaFarhan · 2022-10-28T04:37:50Z

I was not able to reproduce the issue. I have tried different situations. I turned off the internet before the test and while doing the test.
Anyway, I have added error catching for the boost asio. Can you please try again and check if it still crashes from your end?
thanks

jamescowens · 2022-10-30T16:21:41Z

@MinaFarhan I have some more fixes for your branch (PR) here that solves the issue I was having and some other stuff, like the Bionic problem above. The error catching that you put in does not work in Bionic, because boost 1.65 doesn't have results_type. I made some changes and I think everything works now.

jamescowens · 2022-10-30T16:27:26Z

@MinaFarhan please merge my PR and let it flow here. Then this should be ready to merge.

util: Fix some bugs due to new implementation and change in BOINC dir handling

jamescowens

tACK.

jamescowens · 2022-10-31T00:49:10Z

This is ready to merge. The next thing on this is an rpc command to do diagnostics using this core library.

MinaFarhan · 2022-10-31T02:30:03Z

I have added rpc command "walletdiagnose",

Thank you,
the RPC command is actually there. I have added rpc command "walletdiagnose". It is submitted in "ee0fda0e4e1b44b2eb9fc26e638faf19f6adef12"

Thanks
Mina

jamescowens · 2022-10-31T02:52:57Z

There is still an issue about crashing on the assert. I will track this down. assert(m_name_to_test_map.size() < Diagnose::TestSize);

jamescowens · 2022-10-31T03:36:07Z

This is the problem...

2022-10-31T03:31:56Z Using data directory /home/jowens/.GridcoinResearch2/testnet

2022-10-31T03:31:56Z Gridcoin version v5.4.0.2-ae6b4bc35718-dirty (release build)
2022-10-31T03:31:59Z INFO: Diagnose: m_test_name = 144
2022-10-31T03:31:59Z INFO: registerTest: test->m_test_name enum 144 registered, test map size = 1, Diagnose::TestSize = 12
2022-10-31T03:31:59Z INFO: VerifyWalletIsSynced: m_test_name = 2
2022-10-31T03:31:59Z INFO: Diagnose: m_test_name = 2
2022-10-31T03:31:59Z INFO: registerTest: test->m_test_name enum 2 registered, test map size = 2, Diagnose::TestSize = 12
2022-10-31T03:31:59Z INFO: CheckOutboundConnectionCount: m_test_name = 1
2022-10-31T03:31:59Z INFO: Diagnose: m_test_name = -150333728
2022-10-31T03:31:59Z INFO: registerTest: test->m_test_name enum -150333728 registered, test map size = 3, Diagnose::TestSize = 12
2022-10-31T03:31:59Z INFO: CheckConnectionCount: m_test_name = 0
2022-10-31T03:31:59Z INFO: Diagnose: m_test_name = 2
2022-10-31T03:31:59Z INFO: registerTest: test->m_test_name enum 2 registered, test map size = 3, Diagnose::TestSize = 12
2022-10-31T03:31:59Z INFO: VerifyClock: m_test_name = 8
2022-10-31T03:31:59Z INFO: Diagnose: m_test_name = 1451884496
2022-10-31T03:31:59Z INFO: registerTest: test->m_test_name enum 1451884496 registered, test map size = 4, Diagnose::TestSize = 12
2022-10-31T03:31:59Z INFO: CheckClientVersion: m_test_name = 3
2022-10-31T03:31:59Z INFO: Diagnose: m_test_name = 2610
2022-10-31T03:31:59Z INFO: registerTest: test->m_test_name enum 2610 registered, test map size = 5, Diagnose::TestSize = 12
2022-10-31T03:31:59Z INFO: VerifyBoincPath: m_test_name = 4
2022-10-31T03:31:59Z INFO: Diagnose: m_test_name = 144
2022-10-31T03:31:59Z INFO: registerTest: test->m_test_name enum 144 registered, test map size = 5, Diagnose::TestSize = 12
2022-10-31T03:31:59Z INFO: VerifyCPIDValid: m_test_name = 7
2022-10-31T03:31:59Z INFO: Diagnose: m_test_name = 1449514896
2022-10-31T03:31:59Z INFO: registerTest: test->m_test_name enum 1449514896 registered, test map size = 6, Diagnose::TestSize = 12
2022-10-31T03:31:59Z INFO: VerifyCPIDHasRAC: m_test_name = 5
2022-10-31T03:31:59Z INFO: Diagnose: m_test_name = 1442843186
2022-10-31T03:31:59Z INFO: registerTest: test->m_test_name enum 1442843186 registered, test map size = 7, Diagnose::TestSize = 12
2022-10-31T03:31:59Z INFO: VerifyCPIDIsActive: m_test_name = 6
2022-10-31T03:31:59Z INFO: Diagnose: m_test_name = 7471220
2022-10-31T03:31:59Z INFO: registerTest: test->m_test_name enum 7471220 registered, test map size = 8, Diagnose::TestSize = 12
2022-10-31T03:31:59Z INFO: VerifyTCPPort: m_test_name = 9
2022-10-31T03:31:59Z INFO: Diagnose: m_test_name = 2610
2022-10-31T03:31:59Z INFO: registerTest: test->m_test_name enum 2610 registered, test map size = 8, Diagnose::TestSize = 12
2022-10-31T03:31:59Z INFO: CheckDifficulty: m_test_name = 10
2022-10-31T03:31:59Z INFO: Diagnose: m_test_name = 1449260224
2022-10-31T03:31:59Z INFO: registerTest: test->m_test_name enum 1449260224 registered, test map size = 9, Diagnose::TestSize = 12
2022-10-31T03:31:59Z INFO: CheckETTS: m_test_name = 11

The constructor for Dialog is trying to register the test before the m_test_name is set.

jamescowens · 2022-10-31T03:44:24Z

Ok... this is better...

2022-10-31T03:43:35Z Using data directory /home/jowens/.GridcoinResearch2/testnet

2022-10-31T03:43:35Z Gridcoin version v5.4.0.2-ae6b4bc35718-dirty (release build)
2022-10-31T03:43:37Z INFO: Diagnose: m_test_name = 2
2022-10-31T03:43:37Z INFO: registerTest: test->m_test_name enum 2 registered, test map size = 1, Diagnose::TestSize = 12
2022-10-31T03:43:37Z INFO: Diagnose: m_test_name = 1
2022-10-31T03:43:37Z INFO: registerTest: test->m_test_name enum 1 registered, test map size = 2, Diagnose::TestSize = 12
2022-10-31T03:43:37Z INFO: CheckOutboundConnectionCount: m_test_name = 1
2022-10-31T03:43:37Z INFO: Diagnose: m_test_name = 0
2022-10-31T03:43:37Z INFO: registerTest: test->m_test_name enum 0 registered, test map size = 3, Diagnose::TestSize = 12
2022-10-31T03:43:37Z INFO: CheckConnectionCount: m_test_name = 0
2022-10-31T03:43:37Z INFO: Diagnose: m_test_name = 8
2022-10-31T03:43:37Z INFO: registerTest: test->m_test_name enum 8 registered, test map size = 4, Diagnose::TestSize = 12
2022-10-31T03:43:37Z INFO: VerifyClock: m_test_name = 8
2022-10-31T03:43:37Z INFO: Diagnose: m_test_name = 3
2022-10-31T03:43:37Z INFO: registerTest: test->m_test_name enum 3 registered, test map size = 5, Diagnose::TestSize = 12
2022-10-31T03:43:37Z INFO: CheckClientVersion: m_test_name = 3
2022-10-31T03:43:37Z INFO: Diagnose: m_test_name = 4
2022-10-31T03:43:37Z INFO: registerTest: test->m_test_name enum 4 registered, test map size = 6, Diagnose::TestSize = 12
2022-10-31T03:43:37Z INFO: VerifyBoincPath: m_test_name = 4
2022-10-31T03:43:37Z INFO: Diagnose: m_test_name = 7
2022-10-31T03:43:37Z INFO: registerTest: test->m_test_name enum 7 registered, test map size = 7, Diagnose::TestSize = 12
2022-10-31T03:43:37Z INFO: VerifyCPIDValid: m_test_name = 7
2022-10-31T03:43:37Z INFO: Diagnose: m_test_name = 5
2022-10-31T03:43:37Z INFO: registerTest: test->m_test_name enum 5 registered, test map size = 8, Diagnose::TestSize = 12
2022-10-31T03:43:37Z INFO: VerifyCPIDHasRAC: m_test_name = 5
2022-10-31T03:43:37Z INFO: Diagnose: m_test_name = 6
2022-10-31T03:43:37Z INFO: registerTest: test->m_test_name enum 6 registered, test map size = 9, Diagnose::TestSize = 12
2022-10-31T03:43:37Z INFO: VerifyCPIDIsActive: m_test_name = 6
2022-10-31T03:43:37Z INFO: Diagnose: m_test_name = 9
2022-10-31T03:43:37Z INFO: registerTest: test->m_test_name enum 9 registered, test map size = 10, Diagnose::TestSize = 12
2022-10-31T03:43:37Z INFO: VerifyTCPPort: m_test_name = 9
2022-10-31T03:43:37Z INFO: Diagnose: m_test_name = 10
2022-10-31T03:43:37Z INFO: registerTest: test->m_test_name enum 10 registered, test map size = 11, Diagnose::TestSize = 12
2022-10-31T03:43:37Z INFO: CheckDifficulty: m_test_name = 10
2022-10-31T03:43:37Z INFO: Diagnose: m_test_name = 11
2022-10-31T03:43:37Z INFO: registerTest: test->m_test_name enum 11 registered, test map size = 12, Diagnose::TestSize = 12

jamescowens · 2022-10-31T03:52:53Z

I just pushed two additional commits directly to development to fix this issue.
ae6b4bc
4be2469

jamescowens · 2022-10-31T14:01:32Z

A few more cleanup commits directly to development branch that are followons to this PR.
da333ca
1239ac0
1239ac0
e325567

I think there is still something not quite right with the clock test, because even with more than 5 connections the clock test does not return immediately all of the time. I will do some more investigation of that.

@Pythonix

Added - net: Add and document network messages in protocol.h (backport) gridcoin-community#2533 (@Pythonix) - Define MAX_DIGITS_BTC for magic number in BitcoinUnits::format gridcoin-community#2555 (@barton2526) - rpc: Implementation of getmrcinfo gridcoin-community#2570 (@jamescowens) - init: Add init error message if -printtoconsole and -daemon specified simultaneously gridcoin-community#2571 (@jamescowens) - rpc: getmrcinfo part 2 - add calculated minimum fees and fee boosting and by CPID reporting gridcoin-community#2575 (@jamescowens) - fs: fully initialize `_OVERLAPPED` for win32 gridcoin-community#2587 (@div72) - util: Diagnose Lib Version #1 gridcoin-community#2573 (@MinaFarhan) - util: Implement core diagnostics #2 (@jamescowens) - util: modify Win32LockedPageAllocator to query windows for limit. gridcoin-community#2536 (@div72) - gui, voting: Implement information for wallet holder's votes on poll info cards gridcoin-community#2605 (@jamescowens) Changed - scripted-diff: Drop Darwin version for better maintainability gridcoin-community#2557 (@barton2526) - build: Require gcc8 on Ubuntu Bionic to enable C++17 features gridcoin-community#2579 (@barton2526) - util: Replace use of locale dependent atoi(…) with locale-independent std::from_chars(…) (C++17) gridcoin-community#2564 (@barton2526) - translation: Translation updates gridcoin-community#2581 (@jamescowens) - depends: update urls for dmg tools gridcoin-community#2583 (@div72) - Use ReadLE64 in uint256::GetUint64 instead of duplicating logic gridcoin-community#2586 (@div72) - util: Make Parse{Int,UInt}{32,64} use locale independent std::from_chars(…) (C++17) instead of locale dependent strto{l,ll,ul,ull} gridcoin-community#2592 (@barton2526) - build: don't set PORT=no in config.site gridcoin-community#2593 (@barton2526) - build: Replace `which` command with `command -v` gridcoin-community#2595 (@barton2526) - build: update ax_cxx_compile_stdcxx to serial 14 gridcoin-community#2596 (@barton2526) - gui: Changed the unlocked for staking only icons to green gridcoin-community#2598 (@delta1513) - gui: Translation updates gridcoin-community#2599 (@jamescowens) - build: update CI for linter and actions version gridcoin-community#2606 (@jamescowens) - gui: Update translations gridcoin-community#2608 (@jamescowens) Removed - refactor: remove unused c-string variant of atoi64() gridcoin-community#2562 (@barton2526) - refactor: Remove unused CDataStream::rdbuf method gridcoin-community#2585 (@div72) Fixed - net: Fix some benign races (backport) gridcoin-community#2532 (@Pythonix) - rpc: fix invalid parameter error codes for {sign,verify}message RPCs gridcoin-community#2556 (@barton2526) - build: Fix x86_64 <-> arm64 cross-compiling for macOS gridcoin-community#2560 (@barton2526) - rpc, mrc: Fix field name and initialization of mrc_fees_to_staker gridcoin-community#2567 (@jamescowens) - gui: Add missing resizeTableColumns to fix send address book column widths gridcoin-community#2569 (@jamescowens) - accrual: rebuild snapshot registry on corruption instead of crashing gridcoin-community#2577 (@div72) - doc: Fix link to MurmurHash3.cpp (moved from Google Code to Github) gridcoin-community#2584 (@div72) - fix help text for `revokebeacon` command gridcoin-community#2591 (@Pythonix) - util: Fix spelling error in gridcoinresearchd.cpp gridcoin-community#2590 (@jamescowens) - depends: always use correct ar for win qt build gridcoin-community#2588 (@div72) - util: Fix some bugs due to new implementation and change in BOINC dir handling (@jamescowens) - util: Diagnose lib - Implement changes to solve crash on some Boost 1.66 machines gridcoin-community#2597 (@jamescowens) - contrib: Check for `patch` command, Check for `wget` command gridcoin-community#2594 (@barton2526) - build: Check std::system for -[alert|block|wallet]notify gridcoin-community#2582 (@barton2526) - gui: Changed the wording on the tooltip for the address book gridcoin-community#2602 (@delta1513) - build: pass win32-dll to LT_INIT() gridcoin-community#2601 (@barton2526) - build: minor cleanups to native_clang package gridcoin-community#2600 (@barton2526) - util: restore translations to diagnostics gridcoin-community#2603 (@jamescowens) - refactor: Fix problems found by valgrind gridcoin-community#2607 (@jamescowens)

Diagnose Lib Version #1

466af39

MinaFarhan marked this pull request as draft September 10, 2022 15:21

div72 assigned MinaFarhan Sep 10, 2022

div72 added enhancement refactor This is for refactoring (if also an enhancement, use that label too). labels Sep 10, 2022

jamescowens changed the title ~~Diagnose Lib Version #1~~ util: Diagnose Lib Version #1 Sep 11, 2022

jamescowens added this to the LaVerne milestone Sep 11, 2022

jamescowens reviewed Sep 11, 2022

View reviewed changes

src/Makefile.qt.include Outdated Show resolved Hide resolved

jamescowens reviewed Sep 11, 2022

View reviewed changes

src/Makefile.qt.include Outdated Show resolved Hide resolved

jamescowens requested changes Sep 11, 2022

View reviewed changes

Chaniging name of Diagnose.cpp

2ce3c8a

barton2526 reviewed Sep 19, 2022

View reviewed changes

jamescowens requested changes Oct 9, 2022

View reviewed changes

src/Makefile.am Outdated Show resolved Hide resolved

src/Makefile.am Outdated Show resolved Hide resolved

src/qt/diagnosticsdialog.cpp Outdated Show resolved Hide resolved

src/qt/diagnosticsdialog.cpp Outdated Show resolved Hide resolved

Add LogPrintf to registerTest for troubleshooting

8c15e83

This commit should be removed before merge to development.

jamescowens reviewed Oct 23, 2022

View reviewed changes

src/wallet/rpcwallet.cpp Show resolved Hide resolved

src/wallet/diagnose.h Outdated Show resolved Hide resolved

src/wallet/diagnose.h Show resolved Hide resolved

MinaFarhan added 2 commits October 23, 2022 22:05

Merge pull request #2 from jamescowens/implement_core_diagnostics

caaf952

util: Implement core diagnostics

Merge branch 'gridcoin-community:development' into DiagnoseLib

4f662ba

Added error catching for boost asio

e0168e8

jamescowens and others added 2 commits October 30, 2022 12:30

Fix some bugs due to new implementation and change in BOINC dir handling

8b21110

Merge pull request #3 from jamescowens/implement_core_diagnostics

e5f49fc

util: Fix some bugs due to new implementation and change in BOINC dir handling

MinaFarhan requested a review from jamescowens October 31, 2022 00:36

jamescowens approved these changes Oct 31, 2022

View reviewed changes

jamescowens merged commit b0b8f1a into gridcoin-community:development Oct 31, 2022

util: Diagnose Lib Version #1 #2573

util: Diagnose Lib Version #1 #2573

Conversation

MinaFarhan commented Sep 9, 2022 • edited by jamescowens Loading

MinaFarhan commented Sep 9, 2022

Pythonix commented Sep 9, 2022 • edited Loading

iFoggz commented Sep 10, 2022

iFoggz commented Sep 10, 2022

jamescowens commented Sep 11, 2022

jamescowens left a comment

Choose a reason for hiding this comment

jamescowens commented Sep 11, 2022

MinaFarhan commented Sep 11, 2022

MinaFarhan commented Sep 11, 2022

jamescowens commented Sep 13, 2022 • edited Loading

MinaFarhan commented Sep 14, 2022

MinaFarhan commented Sep 19, 2022

MinaFarhan commented Oct 1, 2022

jamescowens commented Oct 4, 2022

MinaFarhan commented Oct 4, 2022

MinaFarhan commented Oct 8, 2022

jamescowens left a comment

Choose a reason for hiding this comment

jamescowens commented Oct 9, 2022

MinaFarhan commented Oct 10, 2022

jamescowens commented Oct 23, 2022

jamescowens commented Oct 23, 2022

jamescowens commented Oct 24, 2022

jamescowens commented Oct 24, 2022

MinaFarhan commented Oct 25, 2022

MinaFarhan commented Oct 25, 2022

MinaFarhan commented Oct 25, 2022

jamescowens commented Oct 25, 2022

jamescowens commented Oct 25, 2022

MinaFarhan commented Oct 28, 2022

jamescowens commented Oct 30, 2022

jamescowens commented Oct 30, 2022

jamescowens left a comment

Choose a reason for hiding this comment

jamescowens commented Oct 31, 2022

MinaFarhan commented Oct 31, 2022

jamescowens commented Oct 31, 2022

jamescowens commented Oct 31, 2022

jamescowens commented Oct 31, 2022

jamescowens commented Oct 31, 2022

jamescowens commented Oct 31, 2022

MinaFarhan commented Sep 9, 2022 •

edited by jamescowens

Loading

Pythonix commented Sep 9, 2022 •

edited

Loading

jamescowens commented Sep 13, 2022 •

edited

Loading