diagnose, rpc: fix compilation with boost 1.87 #2786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Opensuse Leap 15.6 is still at 1.66.0, but that is ok with this. The CI still didn't pass. You could put #ifdef around this dependent on the boost version and make it work for earlier boost, although I don't know of any distributions that would actually need that. |
div72
changed the title
gentoo-repo-qa-bot
pushed a commit
to gentoo-mirror/seden
that referenced
this pull request
Dec 22, 2024
There are efforts being made for the next version to be compatible. See: gridcoin-community/Gridcoin-Research#2786 Signed-off-by: Sven Eden <[email protected]>
gentoo-bot
pushed a commit
to gentoo/guru
that referenced
this pull request
Jan 6, 2025
Gridcoin is not yet compatible with Boost 1.87.0. See: gridcoin-community/Gridcoin-Research#2786 Signed-off-by: Anna (cybertailor) Vyalkova <[email protected]>
div72
changed the title
`boost::asio::ip::tcp::resolver::query` has been removed in 1.87 which causes compilation issues. This raises the minimum supported version of Boost to 1.66 which should be safe since near-EOL focal has 1.71.
`boost::asio::ip::tcp::resolver::iterator` has been removed in Boost 1.87.
I'm at a loss for words.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
boost::asio::ip::tcp::resolver::queryhas been removed in 1.87 which causes compilation issues.boost::asio::ip::tcp::resolver::iteratorhas been removed in 1.87 which causes compilation issues.boost::asio::ip::socket_base::max_connectionshas been renamed tomax_listen_connections.boost::asio::ip::address_v6::to_v4(),boost::asio::ip::address_v6::is_v4_compatible()andboost::asio::ip::address_v4::to_ulonghas been removed.This raises the minimum supported version of Boost to 1.66 which should be safe to do since near-EOL focal has 1.71. Ubuntu bionic CI is bumped to accommodate this.
Fixes the CI issue in #2781.