Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New tap changer table for two windings transformer #1091

Merged
merged 120 commits into from
Feb 22, 2023
Merged

New tap changer table for two windings transformer #1091

merged 120 commits into from
Feb 22, 2023

Conversation

flomillot
Copy link
Contributor

@flomillot flomillot commented Feb 10, 2023 •
edited
Loading

Change the tap changer table inside the two windings transformer creation dialog.
Mutualize the code between ratio tap changer and phase tap changer.
US 1724

LE SAULNIER Kevin added 30 commits December 19, 2022 18:08
feat: 1st commit with textfield and select fields
179b167 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
feat: connectivity subform implemented, some bugs remaining
4ddaf8f 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: improve code clarity
bfd69fc 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
feat: component fully working, missing adornments and error translations
5a796bb 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
feat: add adornments + clearable
d66dd57 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
feat: yup config moved to config file
7858bdb 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: eslint warning
c3be108 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: eslint warnings
f5e0c80 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: made inputs better reusable
54f5c3f 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: removed console log
2e58a35 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: remove old dialog
2e9335f 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: Proptypes warnings
f7a9573 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: add clearable to select inputs
e03d907 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
feat: add provider for yup, removed useless control + fix number fields
bf600c5 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: missing import
cf46bc5 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: field type
cacfd59 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: PR remark
223f5e3 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
Merge remote-tracking branch 'origin/main' into rhf-migration-load-cr…
25bf39f 
…eation
fix: add last modifications from main
26f0cec 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
feat: 1st commit for 2wt creation dialog migration
ce47ea6 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: best way to deal with number + error when editing load from a no…
db3c695 
…t existing voltage level + freesolo implementation

Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: removed custom hook to use$ function instead
af16e66 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: PR remark + esLint warning
453150d 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
Merge remote-tracking branch 'origin/main' into rhf-migration-load-cr…
3990a42 
…eation
Merge remote-tracking branch 'origin/rhf-migration-load-creation' int…
baa1839 
…o rhf-migration-2wt-creation
fix: recent added behaviour added
d25cc31 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
Merge remote-tracking branch 'origin/rhf-migration-load-creation' int…
a268729 
…o rhf-migration-2wt-creation
feat: add 1st functionnalities of tables
694e570 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
feat end of 2nd tab with performence issues
af68242 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix wrong proptypes
174d19c 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
flomillot and others added 12 commits February 15, 2023 11:00
@flomillot
Create read only input component
21ff7e4 
Signed-off-by: Florent MILLOT <[email protected]>
@flomillot
Disable the table cell when 'disabled' is true
b6a5079 
Fix height of the table

Signed-off-by: Florent MILLOT <[email protected]>
@flomillot
Fix create rule button and its tooltip position
658d58f 
Signed-off-by: Florent MILLOT <[email protected]>
@flomillot
Disable every components when necessary
5053692 
Signed-off-by: Florent MILLOT <[email protected]>
@flomillot
Reorder disable prop
d89403f 
Signed-off-by: Florent MILLOT <[email protected]>
@flomillot
Update copyright date
66d84eb 
Signed-off-by: Florent MILLOT <[email protected]>
@flomillot
Some code cleaning and renaming
6fb4546 
Signed-off-by: Florent MILLOT <[email protected]>
@flomillot
Refactor a bit adding a row
b3dd5bf 
Signed-off-by: Florent MILLOT <[email protected]>
@anistouri
Modification form loading optimization (#1087)
54d88ba 
This also fixes the bug of 'previousFrequencyRegulation' being set to false when it was not previously set in generator modification dialog 

* modification form loading optimization

Signed-off-by: TOURI ANIS <[email protected]>

* optimization of 2wt and load

Co-authored-by: TOURI Anis <[email protected]>

* optimization of generator

Co-authored-by: TOURI Anis <[email protected]>

* optimization of load and generator modification

Co-authored-by: TOURI Anis <[email protected]>

* clean code

Co-authored-by: TOURI Anis <[email protected]>

* Added modifications based on feedback

Co-authored-by: TOURI Anis <[email protected]>

* Fix Active power regulation value

Co-authored-by: TOURI Anis <[email protected]>

* clean code

* Updated code per review suggestions

Co-authored-by: TOURI Anis <[email protected]>

* fix getting equipement with Built Parent Node

Co-authored-by: TOURI Anis <[email protected]>

* Rename GeneratorInfo

Co-authored-by: TOURI Anis <[email protected]>

* Incorporate review comments

Co-authored-by: TOURI Anis <[email protected]>

* Incorporate review comments

Co-authored-by: TOURI Anis <[email protected]>

* rename voltageLevelsOptions to voltageLevelOptions

* update component doc

Co-authored-by: TOURI Anis <[email protected]>

* fix proptypes and docs

Co-authored-by: TOURI Anis <[email protected]>

---------

Signed-off-by: TOURI ANIS <[email protected]>
@flomillot
Merge branch 'main' into tap-changer-pane-table
5930e43 
# Conflicts:
#	src/components/refactor/dialogs/two-windings-transformer-creation/tap-changer-pane/phase-tap-changer-pane/phase-tap-changer-pane-utils.js
#	src/components/refactor/dialogs/two-windings-transformer-creation/tap-changer-pane/phase-tap-changer-pane/phase-tap-changer-pane.js
#	src/components/refactor/dialogs/two-windings-transformer-creation/tap-changer-pane/ratio-tap-changer-pane/ratio-tap-changer-pane-utils.js
#	src/components/refactor/dialogs/two-windings-transformer-creation/tap-changer-pane/ratio-tap-changer-pane/ratio-tap-changer-pane.js
#	src/components/refactor/utils/field-constants.js
#	src/translations/en.json
#	src/translations/fr.json
@thangqp
Dynamic simulation: Show values in domain X in second (#1100)
29315a7 
+ Rectify Proptypes warnings in console
@flomillot
Fix merge
0303306 
Signed-off-by: Florent MILLOT <[email protected]>
@flomillot
Merge branch 'main' into tap-changer-pane-table
68afa8c 
# Conflicts:
#	src/components/results/dynamicsimulation/dynamic-simulation-result-chart-tabs.js
sBouzols
sBouzols approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@sBouzols sBouzols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review OK
Tests OK
will see later for header background color and buttons showing
Console warning check OK

flomillot and others added 7 commits February 20, 2023 12:20
@flomillot
Improve rendering perf by disabling global style for auto fill
4efc3a0 
Signed-off-by: Florent MILLOT <[email protected]>
@flomillot
Merge branch 'main' into tap-changer-pane-table
3bea2c0
@flomillot
Merge branch 'main' into tap-changer-pane-table
0a595e8
@flomillot
Merge branch 'main' into tap-changer-pane-table
d5e24fb
@sBouzols
Merge branch 'main' into tap-changer-pane-table
aec951f
@flomillot
Fix height of the table
b468a39 
Signed-off-by: Florent MILLOT <[email protected]>
@flomillot
Merge remote-tracking branch 'origin/main' into tap-changer-pane-table
13645d0 
# Conflicts:
#	src/components/refactor/dialogs/two-windings-transformer-creation/tap-changer-pane/phase-tap-changer-pane/phase-tap-changer-pane-utils.js
#	src/components/refactor/dialogs/two-windings-transformer-creation/tap-changer-pane/ratio-tap-changer-pane/ratio-tap-changer-pane-utils.js
@flomillot flomillot merged commit 0c033da into main Feb 22, 2023
@flomillot flomillot deleted the tap-changer-pane-table branch February 22, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sBouzols sBouzols sBouzols approved these changes

@klesaulnier klesaulnier klesaulnier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@flomillot @sBouzols @klesaulnier @anistouri @thangqp