Harden the service, use the memory limit from grol 0.51+ to avoid fatal/crashes, limit length of values in state file #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldemailly
changed the title
ldemailly
changed the title
ldemailly
changed the title
ccoVeille
reviewed
Aug 18, 2024
| @@ -18,5 +23,9 @@ func main() { | |||
| log.Fatalf("DISCORD_BOT_TOKEN must be set") | |||
| } | |||
| AutoLoadSave = !(os.Getenv("GROL_DISABLE_AUTOSAVE") == "1") | |||
| memlimit := debug.SetMemoryLimit(-1) | |||
| if memlimit == math.MaxInt64 { | |||
| log.Fatalf("Memory limit not set, please set GOMEMLIMIT=1GiB or similar") | |||
There was a problem hiding this comment.
Same comment about adding information it's about an env variable
There was a problem hiding this comment.
yeah but I figured the only operator of the bot which is me knows what GOMEMLIMIT= implies :)
| @@ -18,5 +23,9 @@ func main() { | |||
| log.Fatalf("DISCORD_BOT_TOKEN must be set") | |||
| } | |||
| AutoLoadSave = !(os.Getenv("GROL_DISABLE_AUTOSAVE") == "1") | |||
| memlimit := debug.SetMemoryLimit(-1) | |||
There was a problem hiding this comment.
Sane remarka comment would help as this method is uncommon
There was a problem hiding this comment.
also have to know (it's in the doc too) that the default value is MaxInt64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fatal error: runtime: out of memoryinstead a nice: