This repository has been archived by the owner on Sep 4, 2020. It is now read-only.
update templates to grommet 1.9.0, add DXC Theme to cli options #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables the DXC Theme introduced in grommet 1.9.0 to be used with grommet cli.
(see https://github.com/grommet/grommet/tree/v1.9.0/src/scss/dxc)
This PR is motivated by my work with grommet and grommet-cli at DXC, since I am happy to use the new theme in my daily work.
Testing
A website of each template has been created and briefly tested by user interaction.
No newly introduced bugs were discovered.
1.
grommet new --type basic --theme dxc basic-dxc-testyarn run devgrommet new --type docs --theme dxc docs-dxc-testyarn run devgrommet new --type app --theme dxc app-dxc-testyarn run dev-server &; yarn run devChanges
Type of changes