Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParallelTests::Cucumber::FailuresLogger doesn't seem to support Cucumber 2 #406

Open
abotalov opened this issue Jun 17, 2015 · 3 comments
Open

Comments

@abotalov
Copy link
Contributor

As you can see here
https://github.com/cucumber/cucumber/blob/v1.3.x-bugfix/lib/cucumber/formatter/rerun.rb
https://github.com/cucumber/cucumber/blob/master/lib/cucumber/formatter/rerun.rb
the code of Cucumber::Formatter::Rerun has changed significantly between 1.3 and 2.0.

Therefore, I think the existing ParallelTests::Cucumber::FailuresLogger does no longer support Cucumber 2.0 as initialize method no longer sets @lines in a new Cucumber's version.

Previously it was reported in #378

@grosser
Copy link
Owner

grosser commented Jun 17, 2015

Please open a PR to update cucumber and add the option as #378 ... I'd love to get this fixed, but I'm not using cucumber :(

@nunosilva800
Copy link

Not sure if fixed with #604

In my case I had to lock some versions:

gem 'cucumber', '<= 2.99'
gem 'parallel_tests', '< 2.0'

to make this work. (ruby 2.2)

@grosser
Copy link
Owner

grosser commented Nov 20, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants