Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cucumber removing the deprecated formatter API in 4.0 #634

Open
dreamalligator opened this issue Apr 25, 2018 · 8 comments
Open

cucumber removing the deprecated formatter API in 4.0 #634

dreamalligator opened this issue Apr 25, 2018 · 8 comments

Comments

@dreamalligator
Copy link

just a heads up, WARNING: The formatter ParallelTests::Gherkin::RuntimeLogger is using the deprecated formatter API which will be removed in v4.0 of Cucumber.

@grosser
Copy link
Owner

grosser commented Apr 25, 2018 via email

@viraptor
Copy link

viraptor commented May 11, 2018

This seems to show the difference: https://github.com/cucumber/cucumber-ruby/blob/c26c2d102bb72193fe299b2d25edc4e82fdbba54/features/docs/extending_cucumber/custom_formatter.feature#L44-L85

They did jump the gun a bit since there is no migration described publicly anywhere. :(
Running into the same problem, so raised cucumber/cucumber-ruby#1294

@grosser
Copy link
Owner

grosser commented May 11, 2018 via email

@viraptor
Copy link

Already did, edited the comment, but can't edit your email notifications ;)

@grosser
Copy link
Owner

grosser commented May 11, 2018 via email

@Githraine
Copy link

Note, When I run with Cuke-ruby 4.0.0.rc1, I am getting this error:
/home/ec2-user/.rvm/gems/ruby-2.5.1/gems/parallel_tests-2.27.0/lib/parallel_tests/cucumber/scenarios.rb:2:in `require': cannot load such file -- cucumber/core/gherkin/tag_expression (LoadError)
@grosser

@grosser
Copy link
Owner

grosser commented Nov 28, 2018 via email

@Githraine
Copy link

Githraine commented Nov 28, 2018

Be Advised, this is from the Cuke team:

It looks like they are using the gherkin gem directly in ‘parallel_tests/cucumber/scenarios.rb’. A change to the AST generated by gherkin could break them. Which is to say: they would have to update for every major version of gherkin (and 6.0 just came out).

‘cuke_modeler’ would remove that problem because it sits between the gherkin gem and you and handles the AST changes itself.

Also:

The tag expressions handling has been moved to the cucucmber-tag_expressions gem (see the gemspec of cucumber-core)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants